FPGATrackSimInput: Fix cppcheck warnings.

Copying values in range-for.
Prefer preincrement for iterator classes.

Trigger/EFTracking/FPGATrackSim/FPGATrackSimInput/src/FPGATrackSimDetectorTool.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FPGATrackSimDetectorTool.h"
@@ -68,7 +68,7 @@ void FPGATrackSimDetectorTool::dumpGlobalToLocalModuleMap() {
 
   SCT_ID::const_id_iterator wafer_it = m_sctId->wafer_begin();
   SCT_ID::const_id_iterator wafer_end = m_sctId->wafer_end();
-  for (; wafer_it!=wafer_end; wafer_it++) {
+  for (; wafer_it!=wafer_end; ++wafer_it) {
     const Identifier id = *wafer_it;
     const IdentifierHash idhash = m_sctId->wafer_hash(id);
 

Trigger/EFTracking/FPGATrackSim/FPGATrackSimInput/src/FPGATrackSimReadRawRandomHitsTool.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FPGATrackSimInput/FPGATrackSimReadRawRandomHitsTool.h"
@@ -68,14 +68,14 @@ StatusCode FPGATrackSimReadRawRandomHitsTool::readData(FPGATrackSimEventInputHea
     }
   else // not resetting, start by copying over truth information from old header
     {
-      for (auto truthtrack : header->optional().getTruthTracks())
+      for (const auto& truthtrack : header->optional().getTruthTracks())
         {
 	        if (truthtrack.getBarcode() > mbc) mbc = truthtrack.getBarcode();
       	  optional.addTruthTrack(truthtrack);
         }
 
       // now we got the max bar code, copy the offline tracks
-      for (auto offlinetrack : header->optional().getOfflineTracks()) 
+      for (const auto& offlinetrack : header->optional().getOfflineTracks()) 
 	      { 
       	  optional.addOfflineTrack(offlinetrack);
       	}