From a9539b2627e2bfd7dd519681073d3de5a3995502 Mon Sep 17 00:00:00 2001
From: Shaun Roe <shaun.roe@cern.ch>
Date: Wed, 19 Feb 2025 15:54:30 +0100
Subject: [PATCH] fix minor defects in InDetConditions
---
.../PixelConditionsAlgorithms/src/PixelCablingCondAlg.cxx | 4 ++--
.../SCT_ConditionsData/src/SCT_DCSStatCondData.cxx | 4 ++--
.../SCT_ConditionsData/src/SCT_MonitorCondData.cxx | 4 ++--
.../InDetConditions/TRT_ConditionsAlgs/src/TRTToTCondAlg.cxx | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelCablingCondAlg.cxx b/InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelCablingCondAlg.cxx
index cddc46f15b53..ff828e9d8ab5 100644
--- a/InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelCablingCondAlg.cxx
+++ b/InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelCablingCondAlg.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
*/
#include "PixelCablingCondAlg.h"
@@ -208,7 +208,7 @@ StatusCode PixelCablingCondAlg::execute(const EventContext& ctx) const {
}
ATH_MSG_DEBUG("Size of ROD readoutspeed map: " << rodReadoutMap.size());
- writeCdo->set_readout_map(rodReadoutMap);
+ writeCdo->set_readout_map(std::move(rodReadoutMap));
if (writeHandle.record(std::move(writeCdo)).isFailure()) {
ATH_MSG_FATAL("Could not record PixelCablingCondData " << writeHandle.key() << " with EventRange " << writeHandle.getRange() << " into Conditions Store");
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_DCSStatCondData.cxx b/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_DCSStatCondData.cxx
index 26e0fb96be46..abbf12e16a07 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_DCSStatCondData.cxx
+++ b/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_DCSStatCondData.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
*/
//Implementation file for the data object class
@@ -31,7 +31,7 @@ void SCT_DCSStatCondData::fill(const CondAttrListCollection::ChanNum& chanNum, c
// if this parameter (hv, chanstat etc) doesn't exist in the list add it to the param std::vector
par.push_back(param);
//don't insert! not a new map entry, just update the std::vector
- (*m_bad_channels.find(chanNum)).second = par;
+ (*m_bad_channels.find(chanNum)).second = std::move(par);
}
} else {
// no entry yet for this chan num, so start fresh
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_MonitorCondData.cxx b/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_MonitorCondData.cxx
index 29dbf54a1031..e58b539d0018 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_MonitorCondData.cxx
+++ b/InnerDetector/InDetConditions/SCT_ConditionsData/src/SCT_MonitorCondData.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
*/
//----------------------------------------------------------------------
@@ -31,7 +31,7 @@ bool SCT_MonitorCondData::find(const IdentifierHash& hash, std::string& defectLi
std::size_t moduleIndex{static_cast<std::size_t>(hash/SCT_ConditionsData::SIDES_PER_MODULE)};
std::string result{m_defectListArray[moduleIndex]};
if (result.empty()) return false;
- defectList = result;
+ defectList = std::move(result);
return true;
}
diff --git a/InnerDetector/InDetConditions/TRT_ConditionsAlgs/src/TRTToTCondAlg.cxx b/InnerDetector/InDetConditions/TRT_ConditionsAlgs/src/TRTToTCondAlg.cxx
index 97c3a9be4ee4..31fa846188d8 100644
--- a/InnerDetector/InDetConditions/TRT_ConditionsAlgs/src/TRTToTCondAlg.cxx
+++ b/InnerDetector/InDetConditions/TRT_ConditionsAlgs/src/TRTToTCondAlg.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
*/
#include "TRTToTCondAlg.h"
@@ -129,7 +129,7 @@ StatusCode TRTToTCondAlg::update1( TRTDedxcorrection& Dedxcorrection, const Cond
}
currentArrayValues.push_back(channel->second["array_value"].data<float>());
}
- resultDict[dictNames[channelIndex]] = currentArrayValues;
+ resultDict[dictNames[channelIndex]] = std::move(currentArrayValues);
// update dEdx corrections from dictionary depending on the DB version
if(dataBaseType==kNewDB or dataBaseType==kNewDBOccCorr) {
--
GitLab