Skip to content
Snippets Groups Projects
Commit b1c48d10 authored by Shaun Roe's avatar Shaun Roe Committed by Edward Moyse
Browse files

main-coverity-tauRecTools 

main-coverity-tauRecTools
parent b3c6a27d
No related branches found
No related tags found
24 merge requests!78241Draft: FPGATrackSim: GenScan code refactor,!78236Draft: Switching Streams https://its.cern.ch/jira/browse/ATR-27417,!78056AFP monitoring: new synchronization and cleaning,!78041AFP monitoring: new synchronization and cleaning,!77990Updating TRT chip masks for L1TRT trigger simulation - ATR-28372,!77733Draft: add new HLT NN JVT, augmented with additional tracking information,!77731Draft: Updates to ZDC reconstruction,!77728Draft: updates to ZDC reconstruction,!77522Draft: sTGC Pad Trigger Emulator,!76725ZdcNtuple: Fix cppcheck warning.,!76611L1CaloFEXByteStream: Fix out-of-bounds array accesses.,!76475Punchthrough AF3 implementation in FastG4,!76474Punchthrough AF3 implementation in FastG4,!75729New implementation of ZDC nonlinear FADC correction.,!75703Draft: Update to HI han config for HLT jets,!75184Draft: Update file heavyions_run.config,!74430Draft: Fixing upper bound for Delayed Jet Triggers,!73963Changing the path of the histograms to "Expert" area,!73875updating ID ART reference plots,!73874AtlasCLHEP_RandomGenerators: Fix cppcheck warnings.,!73449Add muon detectors to DarkJetPEBTLA partial event building,!73343Draft: [TrigEgamma] Add photon ringer chains on bootstrap mechanism,!72336Fixed TRT calibration crash,!72279main-coverity-tauRecTools
Hide whitespace changes
Inline Side-by-side
Reconstruction/tauRecTools/Root/lwtnn/Stack.cxx
+ 17
− 17
View file @ b1c48d10
/*
Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
#include "tauRecTools/lwtnn/Stack.h"
......@@ -424,7 +424,7 @@ namespace lwtDev {
// __________________________________________________________________
// Recurrent layers
EmbeddingLayer::EmbeddingLayer(int var_row_index, MatrixXd W):
EmbeddingLayer::EmbeddingLayer(int var_row_index, const MatrixXd & W):
m_var_row_index(var_row_index),
m_W(W)
{
......@@ -470,14 +470,14 @@ namespace lwtDev {
// LSTM layer
LSTMLayer::LSTMLayer(ActivationConfig activation,
ActivationConfig inner_activation,
MatrixXd W_i, MatrixXd U_i, VectorXd b_i,
MatrixXd W_f, MatrixXd U_f, VectorXd b_f,
MatrixXd W_o, MatrixXd U_o, VectorXd b_o,
MatrixXd W_c, MatrixXd U_c, VectorXd b_c,
bool go_backwards,
bool return_sequence):
LSTMLayer::LSTMLayer(const ActivationConfig & activation,
const ActivationConfig & inner_activation,
const MatrixXd & W_i, const MatrixXd & U_i, const VectorXd & b_i,
const MatrixXd & W_f, const MatrixXd & U_f, const VectorXd & b_f,
const MatrixXd & W_o, const MatrixXd & U_o, const VectorXd & b_o,
const MatrixXd & W_c, const MatrixXd & U_c, const VectorXd & b_c,
bool go_backwards,
bool return_sequence):
m_W_i(W_i),
m_U_i(U_i),
m_b_i(b_i),
......@@ -547,11 +547,11 @@ namespace lwtDev {
// GRU layer
GRULayer::GRULayer(ActivationConfig activation,
ActivationConfig inner_activation,
MatrixXd W_z, MatrixXd U_z, VectorXd b_z,
MatrixXd W_r, MatrixXd U_r, VectorXd b_r,
MatrixXd W_h, MatrixXd U_h, VectorXd b_h):
GRULayer::GRULayer(const ActivationConfig & activation,
const ActivationConfig & inner_activation,
const MatrixXd & W_z, const MatrixXd & U_z, const VectorXd & b_z,
const MatrixXd & W_r, const MatrixXd & U_r, const VectorXd & b_r,
const MatrixXd & W_h, const MatrixXd & U_h, const VectorXd & b_h):
m_W_z(W_z),
m_U_z(U_z),
m_b_z(b_z),
......@@ -621,8 +621,8 @@ namespace lwtDev {
}
MatrixXd BidirectionalLayer::scan( const MatrixXd& x) const{
MatrixXd forward = m_forward_layer->scan(x);
MatrixXd backward = m_backward_layer->scan(x);
const MatrixXd & forward = m_forward_layer->scan(x);
const MatrixXd & backward = m_backward_layer->scan(x);
MatrixXd backward_rev;
if (m_return_sequence){
backward_rev = backward.rowwise().reverse();
......
Reconstruction/tauRecTools/tauRecTools/lwtnn/Stack.h
+ 13
− 13
View file @ b1c48d10
/*
Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
#ifndef STACK_HH_TAURECTOOLS
......@@ -222,7 +222,7 @@ namespace lwtDev {
class EmbeddingLayer : public IRecurrentLayer
{
public:
EmbeddingLayer(int var_row_index, MatrixXd W);
EmbeddingLayer(int var_row_index, const MatrixXd & W);
virtual ~EmbeddingLayer() {};
virtual MatrixXd scan( const MatrixXd&) const override;
......@@ -236,12 +236,12 @@ namespace lwtDev {
class LSTMLayer : public IRecurrentLayer
{
public:
LSTMLayer(ActivationConfig activation,
ActivationConfig inner_activation,
MatrixXd W_i, MatrixXd U_i, VectorXd b_i,
MatrixXd W_f, MatrixXd U_f, VectorXd b_f,
MatrixXd W_o, MatrixXd U_o, VectorXd b_o,
MatrixXd W_c, MatrixXd U_c, VectorXd b_c,
LSTMLayer(const ActivationConfig & activation,
const ActivationConfig & inner_activation,
const MatrixXd & W_i, const MatrixXd & U_i, const VectorXd & b_i,
const MatrixXd & W_f, const MatrixXd & U_f, const VectorXd & b_f,
const MatrixXd & W_o, const MatrixXd & U_o, const VectorXd & b_o,
const MatrixXd & W_c, const MatrixXd & U_c, const VectorXd & b_c,
bool go_backwards,
bool return_sequence);
......@@ -277,11 +277,11 @@ namespace lwtDev {
class GRULayer : public IRecurrentLayer
{
public:
GRULayer(ActivationConfig activation,
ActivationConfig inner_activation,
MatrixXd W_z, MatrixXd U_z, VectorXd b_z,
MatrixXd W_r, MatrixXd U_r, VectorXd b_r,
MatrixXd W_h, MatrixXd U_h, VectorXd b_h);
GRULayer(const ActivationConfig & activation,
const ActivationConfig & inner_activation,
const MatrixXd & W_z, const MatrixXd & U_z, const VectorXd & b_z,
const MatrixXd & W_r, const MatrixXd & U_r, const VectorXd & b_r,
const MatrixXd & W_h, const MatrixXd & U_h, const VectorXd & b_h);
virtual ~GRULayer() {};
virtual MatrixXd scan( const MatrixXd&) const override;
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment