From d4d48f75610ea79ef22acb4a6f34e0cea3c37fb1 Mon Sep 17 00:00:00 2001
From: scott snyder <snyder@bnl.gov>
Date: Fri, 19 Jul 2024 20:57:41 +0200
Subject: [PATCH] TrigInDetEventTPCnv: Fix genconf warnings.
TPCnv libraries declare Gaudi plugin factories for the TP converters.
Normally, the TPCnv libraries should not be linked against libraries
other than the EventPool libraries. However, it is possible for one
TPCnv library to link against another TPCnv library.
In that case, genconf may emit warnings that one library's factory
is visible from another. Clean up by moving TPCnv factories into their
own libraries (linked against the corresponding TPCnv library).
---
Trigger/TrigEvent/TrigInDetEventTPCnv/CMakeLists.txt | 9 +++++++--
.../src/{ => factories}/TrigInDetEventTPCnv.cxx | 0
2 files changed, 7 insertions(+), 2 deletions(-)
rename Trigger/TrigEvent/TrigInDetEventTPCnv/src/{ => factories}/TrigInDetEventTPCnv.cxx (100%)
diff --git a/Trigger/TrigEvent/TrigInDetEventTPCnv/CMakeLists.txt b/Trigger/TrigEvent/TrigInDetEventTPCnv/CMakeLists.txt
index 98c8496505ff..27bda65d262f 100644
--- a/Trigger/TrigEvent/TrigInDetEventTPCnv/CMakeLists.txt
+++ b/Trigger/TrigEvent/TrigInDetEventTPCnv/CMakeLists.txt
@@ -1,15 +1,20 @@
-# Copyright (C) 2020, 2022 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2020, 2022, 2024 CERN for the benefit of the ATLAS collaboration
# Declare the package name:
atlas_subdir( TrigInDetEventTPCnv )
# Component(s) in the package:
-atlas_add_tpcnv_library( TrigInDetEventTPCnv
+atlas_add_library( TrigInDetEventTPCnv
TrigInDetEventTPCnv/*.h src/*.cxx
PUBLIC_HEADERS TrigInDetEventTPCnv
LINK_LIBRARIES AthenaPoolCnvSvcLib AthenaPoolUtilities EventCommonTPCnv InDetIdentifier RootConversions StoreGateLib TrigCaloEventTPCnv TrigInDetEvent
PRIVATE_LINK_LIBRARIES AthenaKernel IdDictParser )
+atlas_add_tpcnv_library( TrigInDetEventTPCnvFactories
+ src/factories/*.cxx
+ PUBLIC_HEADERS TrigInDetEventTPCnv
+ LINK_LIBRARIES TrigInDetEventTPCnv )
+
atlas_add_dictionary( TrigInDetEventTPCnvDict
TrigInDetEventTPCnv/TrigInDetEventTPCnvDict.h
TrigInDetEventTPCnv/selection.xml
diff --git a/Trigger/TrigEvent/TrigInDetEventTPCnv/src/TrigInDetEventTPCnv.cxx b/Trigger/TrigEvent/TrigInDetEventTPCnv/src/factories/TrigInDetEventTPCnv.cxx
similarity index 100%
rename from Trigger/TrigEvent/TrigInDetEventTPCnv/src/TrigInDetEventTPCnv.cxx
rename to Trigger/TrigEvent/TrigInDetEventTPCnv/src/factories/TrigInDetEventTPCnv.cxx
--
GitLab