Geo2G4: Fix clang warnings.

Clang warnings: unused class members, missing override keywords,
struct/class consistency.

Simulation/G4Utilities/Geo2G4/src/Geo2G4Svc.cxx

@@ -9,7 +9,6 @@ void InitializeBuilders();
 
 Geo2G4Svc::Geo2G4Svc(const std::string& name, ISvcLocator* svcLocator)
   : AthService(name,svcLocator)
-  , m_pIncSvc(nullptr)
   , m_defaultBuilder(nullptr)
   , m_getTopTransform(true)
 {

Simulation/G4Utilities/Geo2G4/src/Geo2G4Svc.h

@@ -23,22 +23,21 @@ public:
   Geo2G4Svc(const std::string& , ISvcLocator *);
   virtual ~Geo2G4Svc();
   /// AthService methods
-  StatusCode initialize() override final;
-  StatusCode finalize() override final;
+  virtual StatusCode initialize() override final;
+  virtual StatusCode finalize() override final;
   virtual StatusCode queryInterface(const InterfaceID& , void** ppvInterface ) override final;
   /// IIncidentListener methods -  FIXME does this service actually need to listen for Incidents?
-  void handle(const Incident&) override final;
+  virtual void handle(const Incident&) override final;
   /// Geo2G4SvcBase methods
   virtual void RegisterVolumeBuilder(VolumeBuilder* vb) override final;
   virtual void UnregisterVolumeBuilder(VolumeBuilder* vb) override final;
-  void SetDefaultBuilder(VolumeBuilder *vb) override final {m_defaultBuilder=vb;}
-  void SetDefaultBuilder(std::string n) override final {this->SetDefaultBuilder(this->GetVolumeBuilder(n));}
-  VolumeBuilder* GetVolumeBuilder(std::string s) const override final;
-  VolumeBuilder* GetDefaultBuilder() const override final {return m_defaultBuilder;}
-  bool UseTopTransforms() const override final {return m_getTopTransform;}
-  void ListVolumeBuilders() const override final;
+  virtual void SetDefaultBuilder(VolumeBuilder *vb) override final {m_defaultBuilder=vb;}
+  virtual void SetDefaultBuilder(std::string n) override final {this->SetDefaultBuilder(this->GetVolumeBuilder(n));}
+  virtual VolumeBuilder* GetVolumeBuilder(std::string s) const override final;
+  virtual VolumeBuilder* GetDefaultBuilder() const override final {return m_defaultBuilder;}
+  virtual bool UseTopTransforms() const override final {return m_getTopTransform;}
+  virtual void ListVolumeBuilders() const override final;
 private:
-  IIncidentSvc* m_pIncSvc; // not used - remove?
   VolumeBuilder *m_defaultBuilder;
   BuilderMap m_builders ;
   bool m_getTopTransform;

Simulation/G4Utilities/Geo2G4/src/LArFanSection.h

@@ -8,8 +8,9 @@
 // helper class to replace G4Polycone
 // in certain LArWheelSolid operations
 
-struct LArFanSections
+class LArFanSections
 {
+public:
 	G4double Amin, Amax;
 	G4double Bmin, Bmax;
 	G4double Amin2, Amax2;