ISF_PunchThroughTools: Fix cppcheck 2.14 warnings.

ISF_PunchThroughTools: Fix cppcheck 2.14 warnings.

Pass containers by const reference, not by value.
Prefer returning const references to members rather than copies.

Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PDFcreator.h

 /*
-  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 ///////////////////////////////////////////////////////////////////
@@ -48,7 +48,7 @@ namespace ISF
 
     /** get the random value with this method, by providing the input parameters */
     double getRand(CLHEP::HepRandomEngine* rndmEngine, const std::vector<int>& inputParameters) const;
-    std::string getName() const {return m_name;};
+    const std::string& getName() const {return m_name;};
 
   private:
     std::string                         m_name;               //!< Give pdf a name for debug purposes

Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx

@@ -966,7 +966,7 @@ std::map<double, double> ISF::PunchThroughTool::getVariableCDFmappings(xmlNodePt
     return mappings;
 }
 
-double ISF::PunchThroughTool::inverseCdfTransform(double variable, std::map<double, double> inverse_cdf_map) {
+double ISF::PunchThroughTool::inverseCdfTransform(double variable, const std::map<double, double>& inverse_cdf_map) {
 
     double norm_cdf = normal_cdf(variable);
 

Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.h

@@ -115,7 +115,7 @@ namespace ISF {
     std::vector<double> inversePCA(int pcaCdfIterator, std::vector<double> &variables) const;
 
     //apply the inverse CDF trainsform
-    static double inverseCdfTransform(double variable, std::map<double, double> inverse_cdf_map) ;
+    static double inverseCdfTransform(double variable, const std::map<double, double>& inverse_cdf_map) ;
 
     //dot product between matrix and vector, used to inverse PCA
     static std::vector<double> dotProduct(const std::vector<std::vector<double>> &m, const std::vector<double> &v) ;