Merge branch 'cppcheck.LArReadoutGeometry-20240301' into 'main'

LArReadoutGeometry: Fix cppcheck warnings.

See merge request !69428

LArCalorimeter/LArGeoModel/LArReadoutGeometry/LArReadoutGeometry/FCAL_ChannelMap.h

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 // ***************************************************************************
@@ -47,7 +47,7 @@ public:
     class TubePosition {                                           //
     public:                                                        //
       TubePosition();                                              //
-      TubePosition(tileName_t name, float x, float y, std::string hvFT);//
+      TubePosition(tileName_t name, float x, float y, const std::string& hvFT);//
       tileName_t  get_tileName() const;                            //
       float       x() const;                                       //
       float       y() const;                                       //
@@ -186,7 +186,7 @@ FCAL_ChannelMap::TubePosition::TubePosition()
 {}
  
 inline
-FCAL_ChannelMap::TubePosition::TubePosition(tileName_t name, float x, float y, std::string hvFT)
+FCAL_ChannelMap::TubePosition::TubePosition(tileName_t name, float x, float y, const std::string& hvFT)
     :
     m_tileName(name),
     m_x(x),

LArCalorimeter/LArGeoModel/LArReadoutGeometry/src/EMECDetectorManager.cxx

 /*
-  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "GaudiKernel/MsgStream.h"
@@ -146,6 +146,7 @@ const EMECHVManager& EMECDetectorManager::getHVManager (EMECHVManager::IOType io
       m_HVManager[io].set (&(manager->getEMECHVManager(io)));
     }
   }
+  // cppcheck-suppress nullPointerRedundantCheck; false positive
   return *(m_HVManager[io].get());
 }