Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

BeamPipeGeoModel: Fix memory leaks.

Fix a few (one-time) memory leaks.

Frank Winklmeier authored 2 years ago and Julien Maurer committed 2 years ago

RecExCommon: remove workaround in B-tagging configuration

Remove `configurableRun3Behavior` workaround in RecExCommon.

Relates to ATLASRECTS-6635.

Adapt to interface changes of `StoredMaterialManager`.

Be explicit if not reference file comparison is used by unit test.

DataQualityInterfaces, LArGeoEndcap, DumpEventDataToJSON, BeamPipeGeoModel cppcheck / clang-tidy fixes

Updated AtlasGeometryCommon packages to use FindGeoModel.cmake. Which was introduced
to serve the new GeoModel uni-project, which was introduced into our build with !39900.

Bonus:
 * Turned CavernInfraGeoModel into component-only package
 * Removed several commented-out include statements from VP1DetInfo.cxx

Dropped the redundant AbsMaterialManager interface, and removed all references to this
interface from client packages.

Dropped redundant methods from RDBMaterialManager, and in this way got rid of lots of
duplicated code.

- remove `atlas_depends_on_subdirs`
- update link dependencies
- replace `atlas_install_headers` with interface library or remove it
  entirely if headers not used outside package
- enable flake8 where applicable

If a dtor is declared final, the class itself should also be declared final.

Library dependency fixes.

In the "new packaging" the external is now called like that...

Updated `ComponentAccumulator` configuration tests which dump the configuration to a pickle file.
In python 3 the output file needs to be explicitly opened in binary mode.
I.e.
```
f = open('configdump.pkl', 'wb')
```
rather than
```
f = open('configdump.pkl', 'w')
```

Fix warnings/errors flagged by `flake8`. Mostly unused variables/imports
or stylistic code problems.

Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb16406dd699b3b8162a9d460b9f91a3a24

Fix coverity warning: potential memory leak on error path.


Former-commit-id: d56d0904

Remove references to obsolete package CLIDSvc.


Former-commit-id: a08d7fe6

coverity: possible null pointer dereference.

Former-commit-id: e9ee2aef

Coverity warning: possible null pointer dereference.
Just remove the null test here; we're not anyway doing anything useful
if it fails.


Former-commit-id: 030f1040

dropped the obsolete reference to Database/AthenaPOOL/RDBAccessSvc
from Projects/AthSimulation/package_filters.txt


Former-commit-id: 7ce3b1e0

The constructors of the following components had to be made public:
AthMpEvtLoopMgr
AthenaConditionStream
AthenaEventLoopMgr
AthenaHiveEventLoopMgr
AthenaOutputStream
AthenaSummarySvc
JobIDSvc
MixingEventSelector
PyAthenaEventLoopMgr
SimplePOSIXTimeKeeperSvc
TestRandomSeqAlg
ClassIDSvc
IOVSvc
PileUpMergeSvc
ProxyProviderSvc
ActiveStoreSvc
SegMemSvc
SGHiveMgrSvc
ByteStreamCnvSvc
ByteStreamCnvSvcBase


Former-commit-id: 982601283edb272066ddf6b446b0484b8082f86f

Vakhtang Tsulaia authored 7 years ago and Adam Edward Barton committed 7 years ago

Former-commit-id: 237a8a9f

Identifiers should not start with underscores.



Former-commit-id: 96b58e74

friend classes (e.g. GeoModelSvc) can call them.

Add mutex protection to several methods of RDBAccessSvc for running in AthenaMT.


Former-commit-id: 84c55bff

	* Switching from IGeoModelSvc to IGeoDbTagSvc

2016-11-17  Vakho Tsulaia  <tsulaia@cern.ch>

	* Replacing endreq with endmsg


Former-commit-id: b846232a