Bertrand Martin Dit Latour authored 9 months ago and Frank Winklmeier committed 9 months ago

TrigGpuTest: restore --CA for RDOtoRDOTrigger

Hello,

Following the removal of '--CA' from trigger ART tests in !71467, one MC test is failing (test_trigGPU_RDOtoRDOTrig_v1Dev_grid). Presumably we need to restore '--CA' for the RDOtoRDOTrigger step (ATR-28807, ATR-29423).

Cheers,
Bertrand

Shaun Roe authored 9 months ago and Frank Winklmeier committed 9 months ago

main-coverity-L1CaloFEXSim

Shaun Roe authored 9 months ago and Frank Winklmeier committed 9 months ago

main-coverity-FPGATrackSimMaps

Jahred Adelman authored 9 months ago and Frank Winklmeier committed 9 months ago

Fix EFTracking CI test

This reverts merge request !71264

Claire Antel authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

TriggerEDMRun3: AODCOMM removal Round 2 (ATR-28561, ATR-28781), Unused/empty AOD removal (ATR-29047)

TriggerEDMRun3,TrigAnalysisTest: Remove HLT_TopoCaloClustersFS from AOD, adjust ART Run3DQ tests to use Trigger.AODEDMSet='ESD'

Jahred Adelman authored 9 months ago and Frank Winklmeier committed 9 months ago

Fix barcode type in FPGATrackSim

Bertrand Martin Dit Latour authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

TriggerJobOpts: update forceConditions postExec

Hello,

In some trigger ART tests, we override conditions by forcing the run number and LB, or the timestamp.
This MR is updating the list of timestamp-based trigger condition folders. The existing list seems otherwise up-to-date, except `/TDAQ/Resources/ATLAS/SCT/Robins` which is apparently unused, maybe it was in Run1 or Run2. Fixes ATR-29380.

Cheers,
Bertrand

Muhammad Alhroob authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

Chains are moved from the Physics Menu to the MC Menu, ATR-29443

Jiri Masik authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

pass flags to getTrigEgammaKeys

Witold Wojciech Przygoda authored 9 months ago and Duc Ta committed 9 months ago

Modified testing condition, special chain cases treatment implemented

Scott Snyder authored 9 months ago and Adam Edward Barton committed 9 months ago

TrigMuonMonitoring: Fix cppcheck warnings.

Pass strings by const reference, not by value.
Fix use of string::find().

Commented out one private data memeber that has recently become unused

Pass object by const reference, not by value.

Pass strings by const reference, not by value.

Gianantonio Pezzullo authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

added L1 and HLT chains to study a possible expansion of the H->tautau and HH->bbtautau trigger selection in the EoF

Marta Lanzac Berrocal authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

ATR-29440: Remove Prescale for L1cTAU30M_2cTAU20M_DR-eTAU30MeTAU20M-jJ55

Jean Yves Beaucamp authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

Added additional eTAU20/eTAU20M T&P chains

Benjamin John Rosser authored 10 months ago and Adam Edward Barton committed 10 months ago

FPGATrackSim: implement loading of radius files in region map class

The map maker generates a "mean radius" file, which until now has only been used by
the 1D Hough transform tool. Since we need the mean radii in order to do the idealized
coordinate transform, it makes sense to move the loading of this file from the Hough
tool into the map infrastructure.

The radius file format is a list of lines, one per subregion, and one inclusive for
the entire region. Each line has a space-separated list of radii for each logical layer.
Since this breaks things down by subregions I added code to load these files into the
FPGATrackSimRegionMap class, which is used for both the region map and subregion map.

If we only have one region in the region map class, we load the line beginning with "-1"
from the radii file. If we have multiple regions we load them based on the (sub)region
number in the radii file. This is a little awkward; right now it works because we have
a separate rmap file for each region that only ever has one region defined.

The 1D Hough tool now just queries the rmap to look up radii, instead of loading the
file separately. At bank generation time we do the same to find the idealized radii instead
of using the hardcoded values in the constants file (which have now been deleted). The
two other places where this were used were the fit constant bank, and the track fitter,
which meant that the rmap needed to be passed into the track fitter (at the moment it
just gets the plane map class). In the track fitter we store a reference to the entire
radius array on the FPGATrackSimTrack class, and use that when computing idealized
coordinates.

Christos Anastopoulos authored 10 months ago and Adam Edward Barton committed 10 months ago

Make EMFourMomBuilder a util

Francesca Pastore authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

Revert truncation of collections in the HLT (ATR-29142)

Remove stray underscore in the default GapFiller tool name.

David Strom authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

B prime zero

Julien Maurer authored 10 months ago and Adam Edward Barton committed 10 months ago

introduce special RETURN_DEFAULT_SCALE_FACTOR for ListOfLegsPerTool property; add 2023 electron triggers

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

TrigEgammaHypo: Fix cppcheck warnings.

Pass object by const reference, not by value.

Remove `--CA` from the transform command lines where obsolete. Note that
the `--CA` option is still needed for steps running RDOtoRDOTrigger.

Suppress bogus cppcheck missingReturn warning.
Prefer returning const references to members rather than copies.

Copying object in range-for.

Copying values in range-for.

Copied values in range-for.

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

TrigConfMuctpi: Fix compilation with boost 1.85.

Fix compilation with boost 1.85 (in lcg3):
can't call get_child() on a temporary ptree.

Bertrand Martin Dit Latour authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

TriggerJobOpts: deploy CONDBR2-HLTP-2024-02

Hello,

The new HLT global conditions tag was validated in HLT reprocessings (ATR-29384, ATR-29387), so we can move from CONDBR2-HLTP-2024-01 (current default) to CONDBR2-HLTP-2024-02.

Cheers,
Bertrand

Francesco Giuseppe Gravili authored 10 months ago and Marija Vranjes Milosavljevic committed 10 months ago

Retrieve value with a dedicated funtion, instead from public/private class member. Updated copyright

Antonio De Maria authored 10 months ago and Dylan Remberto Van Arneman committed 10 months ago

TauTrig: clean TrigTrackPreSelHypoTool code