Christos Anastopoulos authored 7 months ago and Tadej Novak committed 7 months ago

AtlasGeometryCommon : clang-tidy related fixes

Missing override keyword

Deleted one obsolete Factory class. Did some refactoring/cleanup in
other classes

Pass strings by const reference, not by value.
Use boost::starts_with.

Updated AtlasGeometryCommon packages to use FindGeoModel.cmake. Which was introduced
to serve the new GeoModel uni-project, which was introduced into our build with !39900.

Bonus:
 * Turned CavernInfraGeoModel into component-only package
 * Removed several commented-out include statements from VP1DetInfo.cxx

Private data members should start with m_.
Identifiers should not start with underscores.


Former-commit-id: 11f59468

Vakhtang Tsulaia authored 7 years ago and Adam Edward Barton committed 7 years ago

Former-commit-id: 237a8a9f578e5f8c15889235a5f56275ad8eb16d