Siyuan Yan authored 10 months ago and Adam Edward Barton committed 10 months ago

The Master said: To have faults and not to reform them - this, indeed, should be pronounced having faults.

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonR4 - Update R4 test geometry & augment Micromega test

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MMReadoutElementR4 - Streamline interface to always use the identifierHash

Joseph Boudreau authored 10 months ago and Adam Edward Barton committed 10 months ago

Bugfix:  the SQLite workflow is hereby adapted to a recent change in the SQLite database file.

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonHistUtils: Use Accessor, etc instead of auxdata().

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonHoughTransformTester - Add Nsw hits to the Hough tester n-tuple

Edward Moyse authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonGeometryCnv: Attempt to get the alignment stores there

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonSpacePoint formation -- Add sTgc and split the NSW into separate space point container

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonR4 - Continue the development of the fast sTgc digitization

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonPRDTest - Add TGC measurement uncertainty to the tree

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonSpacePoint formation - Add micromegas

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

Do not retrieve the cluster ROT via index

Remove compiler warning

Apply 1 suggestion(s) to 1 file(s)

Apply 1 suggestion(s) to 1 file(s)

Fix CI test

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

HepMcParticleLink constructor syntax clean-up.

Avoid using 0 in combination with HepMcParticleLink::IS_EVENTNUM in constructor calls as this is not properly supported.
It is more correct to directly use 0 with HepMcParticleLink::IS_POSITION to indicate that the link is to the first
GenEvent in the McEventCollection.

Edward Moyse authored 10 months ago and Tadej Novak committed 10 months ago

Call fillCache for sTGC

Edward Moyse authored 10 months ago and Tadej Novak committed 10 months ago

Remove m_useAlignedGeo
Minor fix to match standard naming convention

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

Use the GenEvent event_number in HepMcParticleLink constructors where it is known

Joseph Boudreau authored 10 months ago and Tadej Novak committed 10 months ago

CMakeLists.txt files have been updated for all instances which depend
on the GeoModel core libraries but which do not explicitely include
${GEOMODEL_INCLUDE_DIRS}.  Without this we are in danger of mixing
header files from two sources, and this is actually now happening in
the GeoModel early fault detection pipeline.

Patrick Scholer authored 10 months ago and Ahmed Tarek committed 10 months ago

add cluster theta for error calculation in caruana cluster builder

Patrick Scholer authored 10 months ago and Duc Ta committed 10 months ago

Modify NSWClusterUtils to get local directions given a surface

Bertrand Martin Dit Latour authored 10 months ago and Duc Ta committed 10 months ago

MuonConfig: drop remaining RPC conditions overrides

Hello,

This MR is a follow up of !70390 . With the new HLT global tag CONDBR2-HLTP-2024-01 now in use (https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/ConditionsTagCondbr2hltp202401), we no longer need these RPC conditions overrides.
We may need a new reference due to the change in metadata.

Cheers,
Bertrand

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

Muon geometry - Convert Micromegas from the R4 format into the legacy one

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelR4 - Convert new sTgc readout elements into their legacy version

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonEventTPCnv: Update dummy det description.

Update the dummy detector description used for unit tests.
sTGC will trip an assertion failure if it doesn't see four layers.
Fixes test failures in the debug build.

Maximilian Emanuel Goblirsch-Kolb authored 10 months ago and Tadej Novak committed 10 months ago

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

This was using getChildVol.  However, that keeps track of the transform
to each child, even though that is not actually used.
This is slow, especially in debug builds where Eigen operations
tend to be expensive.

Instead, use GeoVisitVolumes to iterate over children without calculating
the transforms.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelTestR4: cmake fix

Missing find_package for ROOT.

Attila Krasznahorkay authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Made all binaries that depend on LTO, use LTO themselves as well.

Also, moved MuonSensitiveDetectorsR4 into AtlasGeant4.

Sebastian Julio Fuenzalida Garrido authored 10 months ago and Ahmed Tarek committed 10 months ago

Cosmetic changes to sTGC monitoring plots v2

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonEvenTPCnv - Fix unit test

Philip Clark authored 10 months ago and Johannes Elmsheuser committed 10 months ago

p3 version of TP convertors for HepMC particle link v3

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MMReadoutElement - Clean up initialization stage

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonGeoModelTestR4: Fix cppcheck warnings.

Use string::starts_with rather than string::find.

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonReadoutGeometryR4: Speed up handling of tube transforms.

Calling toTubeFrame is expensive, since it needs to walk over all children
until it gets to the desired value.  Hence, calling toTubeFrame from within
a loop over tubes is an N^2 operation.  Further, MdtReadoutElement::initElement()
was calling toTubeFrame multiple times for each tube.
This is especially painful in a debug build, where Eigen matrix operations
are very slow.

Speed up by using GeoVolumeCursor to change from the nested O(N^2) iteration
to a single O(N) iteration, and only evaluate the transform once per tube.

Also fix a logic error the prevented the layer-to-layer pitch test from
executing.

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Muon R4 - Add infrastructure to digitize BI-RPC hits

Paul Nathaniel Swallow authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Improving hashing for BIL with adding the zIndex and changing multidimensional array to a std_unordered map with some input from Johannes