Christos Anastopoulos authored 7 months ago and Tadej Novak committed 7 months ago

AtlasGeometryCommon : clang-tidy related fixes

Deleted one obsolete Factory class. Did some refactoring/cleanup in
other classes

Adapt to interface changes of `StoredMaterialManager`.

Pass strings by const reference, not by value.
Use boost::starts_with.

Dropped the redundant AbsMaterialManager interface, and removed all references to this
interface from client packages.

Dropped redundant methods from RDBMaterialManager, and in this way got rid of lots of
duplicated code.

Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb1

Deprecating use of non-bound DataHandle, especially non-const.
Also adding const for materials.


Former-commit-id: 4c81c8a7

Private data members should start with m_.
Identifiers should not start with underscores.


Former-commit-id: 11f59468

Vakhtang Tsulaia authored 7 years ago and Adam Edward Barton committed 7 years ago

Former-commit-id: 237a8a9f