starts_with.h fix some comments

See merge request !71662

Christos Anastopoulos authored 10 months ago and Adam Edward Barton committed 10 months ago

starts_with.h fix some comments

StoreGateTests: Increase test timeout.

See merge request !71652

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

StoreGateTests: Increase test timeout.

Increase timeout for test which has been timing out frequently in some builds.

FPGATrackSimFitConstantBank: silenced clang warning

See merge request !71660

TrigEgammaMatchingTool+TrigAFPHypo: Fix cppcheck warnings.

See merge request !71657

TrigMuonMonitoring: Fix cppcheck warnings.

See merge request !71658

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

TrigMuonMonitoring: Fix cppcheck warnings.

Pass strings by const reference, not by value.
Fix use of string::find().

MuonR4 - Fix MM digitization in the stereo layers

See merge request !71623

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonR4 - Fix MM digitization in the stereo layers

Simplifying HitNtuple for Hough transform

See merge request !70434

Siyuan Yan authored 10 months ago and Adam Edward Barton committed 10 months ago

The Master said: To have faults and not to reform them - this, indeed, should be pronounced having faults.

LArLATOMEDecoder: Use unique_ptr instead of hand-crafted new/delete

See merge request !71637

Fix for ATLINFR-5383 : only check for files for DiffPool

Closes ATLINFR-5383

See merge request !71664

Edward Moyse authored 10 months ago and Adam Edward Barton committed 10 months ago

Fix for ATLINFR-5383 : only check for files for DiffPool

Commented out one private data memeber that has recently become unused

Pass object by const reference, not by value.

Pass strings by const reference, not by value.

2024-05-23: merge of 24.0 into main

See merge request !71641

MSVertexTracketTool: Fix incorrect sign in tracklet chi squared calculation

Closes ATLASRECTS-7166

See merge request !71606

Michael Revering authored 10 months ago and Adam Edward Barton committed 10 months ago

MSVertexTracketTool: Fix incorrect sign in tracklet chi squared calculation

The MSVertex Tracklet fitting had an incorrect sign in the chi squared
calculation, causing all tracklet segments to fail reconstruction and
no MS Vertices to be produced. This patch changes the sign to the
correct value, returning the MSVertex performance to its run 2 behavior.

Fixes ATLASRECTS-7166

ACTS Pixel seeding Pt cut

See merge request !71265

Luthien Mlynarski authored 10 months ago and Adam Edward Barton committed 10 months ago

ACTS Pixel seeding Pt cut

allow splitting calibration and smearing for e-gamma objects ATLASG-2358

See merge request !71196

Nils Erik Krumnack authored 10 months ago and Adam Edward Barton committed 10 months ago

allow splitting calibration and smearing for e-gamma objects

This is purely experimental and I haven't validated it beyond making
sure it doesn't crash. The main purpose of putting it in is to make it
easier for others to test and validate this.

Note that for the moment this has to recalibrate the objects from
PHYSLITE. This can only be avoided by adding an unsmeared energy to
PHYSLITE (to avoid double-smearing). Still, one step at a time.

SUSY20: adding cleaning tool to properly save TightBad decorations to AntiKt4EMTopoJets

See merge request !71617

Alessandro Sala authored 10 months ago and Adam Edward Barton committed 10 months ago

SUSY20: adding cleaning tool to properly save TightBad decorations to AntiKt4EMTopoJets

Functionalise EMFourMomBuilder

See merge request !71612

Lucy Lewitt authored 10 months ago and Adam Edward Barton committed 10 months ago

Functionalise EMFourMomBuilder

DigitizationTestsMT: dropped beam spot splitting in the mc21a test

See merge request !71540

Fix two issues introduced to LLP1

See merge request !71621

Jackson Carl Burzynski authored 10 months ago and Adam Edward Barton committed 10 months ago

Fix two issues introduced to LLP1

2024-05-22: merge of 24.0 into main

See merge request atlas/athena!71615

FPGATrackSim: implement loading of radius files in region map class

See merge request !70838

Benjamin John Rosser authored 10 months ago and Adam Edward Barton committed 10 months ago

FPGATrackSim: implement loading of radius files in region map class

The map maker generates a "mean radius" file, which until now has only been used by
the 1D Hough transform tool. Since we need the mean radii in order to do the idealized
coordinate transform, it makes sense to move the loading of this file from the Hough
tool into the map infrastructure.

The radius file format is a list of lines, one per subregion, and one inclusive for
the entire region. Each line has a space-separated list of radii for each logical layer.
Since this breaks things down by subregions I added code to load these files into the
FPGATrackSimRegionMap class, which is used for both the region map and subregion map.

If we only have one region in the region map class, we load the line beginning with "-1"
from the radii file. If we have multiple regions we load them based on the (sub)region
number in the radii file. This is a little awkward; right now it works because we have
a separate rmap file for each region that only ever has one region defined.

The 1D Hough tool now just queries the rmap to look up radii, instead of loading the
file separately. At bank generation time we do the same to find the idealized radii instead
of using the hardcoded values in the constants file (which have now been deleted). The
two other places where this were used were the fit constant bank, and the track fitter,
which meant that the rmap needed to be passed into the track fitter (at the moment it
just gets the plane map class). In the track fitter we store a reference to the entire
radius array on the FPGATrackSimTrack class, and use that when computing idealized
coordinates.

Drop obsolete ITruthIncident::updateChildParticle(...) method

See merge request !71626