Renamed ActsTrk::TrackStorageContainer to ActsTrk::TrackSummaryContainer

Closes ATLIDTRKCP-513

See merge request !67999

BTagging clean up

See merge request atlas/athena!68025

Thomas Strebler authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

BTagging clean up

TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone

See merge request atlas/athena!67904

Bertrand Martin Dit Latour authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone

Hello,

When running RDOtoRDOTrigger with the legacy config, it seems that we do not set the LAr config flags correctly. In MC23, LAr flags are set by a preInclude, e.g. `--preInclude "all:Campaigns.MC23a"`, calling [Campaigns/share/MC23a.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Tools/Campaigns/share/MC23a.py), in turn calling [LArConfiguration/share/LArConfigRun3Old.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/LArCalorimeter/LArConfiguration/share/LArConfigRun3Old.py). The jobproperties legacy flags are configured, but not propagated to [TriggerJobOpts/share/runHLT_standalone.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Trigger/TriggerCommon/TriggerJobOpts/share/runHLT_standalone.py) which rely on ConfigFlags. The mapping between legacy and config flags can be found in [thenaConfiguration/python/OldFlags2NewFlags.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Control/AthenaConfiguration/python/OldFlags2NewFlags.py#L109-127). After adding the mapping to runHLT_standalone, we get the following changes for MC23:
* flags.LAr.ROD.nSamples is now 4 instead of 5
* flags.LAr.ROD.UseHighestGainAutoCorr is now True instead of False
* flags.LAr.ROD.NumberOfCollisions is now 60 instead of 0

This bug is affecting the MC21a, MC23a and MC23c campaigns. It's impact is discussed in ATR-28590.

We don't expect the counts to change in the MC CI test, because the test doesn't specify a MC campaign in the preInclude...

The fix improves the agreement between CA and legacy configs (ATR-28470), the CA setup is not affected by the missing flag mapping.

Cheers,
Bertrand

Clean up of FTAG TrackClassificationTools

See merge request atlas/athena!68031

Thomas Strebler authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Clean up of FTAG TrackClassificationTools

Add functionality for DetectorType to ITk Strips

See merge request atlas/athena!68007

Nicholas Styles authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add functionality for DetectorType to ITk Strips

RootUtils+TrigNavStructure+LArCabling: Fix compilation with gcc14.

See merge request atlas/athena!68020

HI: set default test geometry tags

See merge request atlas/athena!68028

Comment out debug printouts

See merge request atlas/athena!67645

TrigInDetTruthEvent+GeoPrimitives: Fix cppcheck warnings.

See merge request !68049

Adding ONNX compatability to FastCaloSim

See merge request atlas/athena!68057

Joshua Falco Beirer authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Told the CMake to ignore pointer lines, and added something to the ref that only seems to appear in the CI...

Clean up InDetalignDBTool

See merge request atlas/athena!68030

Add utility for FastCaloSim standalone

See merge request atlas/athena!68022

Joshua Falco Beirer authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add utility for FastCaloSim standalone

Add protection for photons with no layer 1 EM clusters for pointing tool

See merge request atlas/athena!67984

Thomas Strebler authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add protection for photons with no layer 1 EM clusters for pointing tool

Fixes for executability of ITk alignment tests

See merge request atlas/athena!68011

Nicholas Styles authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Fixes for executability of ITk alignment tests

Add more informative ERROR messages for alignment folders

See merge request !68023

Fix inefficiency plots in the TrigEGamma Monitoring

See merge request !68029

TrigTopoEvent+TrigInDetEvent+TrigCaloEvent: Avoid warnings about implicitly-declared assignment.

See merge request !68016

D3PDMakerUtils: Dump store when we don't properly retrieve an object.

See merge request atlas/athena!68015

MuonRDO+EventBookkeeperMetaData: Avoid warnings about implicitly-declared assignment.

See merge request !68017

minor cleaning of tauRecTools code

See merge request !68003

Add a CovarianceHelper header and relevant tests

See merge request atlas/athena!67987

Christos Anastopoulos authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add a CovarianceHelper header and relevant tests

AthenaConfiguration: Fix asdict() to work with nested flags.

See merge request !68014

AtlasGeoModel+AthenaConfiguration: Support IgnoreTagDifference for CA configuration.

See merge request !68036

Scott Snyder authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

AtlasGeoModel: Support IgnoreTagDifference for CA configuration.

To allow processing samples that were generated	with geometries	which were
later made non-supported.

ZDC config should not configure GeoModelSvc directly

See merge request !68026

BeamEffects: explicitly set geometry to be used in tests

See merge request !68027

InDetGlobalMonitoringRun3Test: Avoid warnings in cosmic runs.

See merge request !68012

PileupReweighting: add common PRW file for MC23d

See merge request !68001

Bertrand Martin Dit Latour authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

PileupReweighting: add common PRW file for MC23d

Hello,

This MR is introducing a common PRW file for the MC23d campaign (`mc23d.450000.physlite.prw.v1.root`), which will be necessary for MC23d DAOD_PHYSLITE production.
I updated the ilumicalc files for data22 and data23, they correspond to the tightest GRLs, assuming these will be used by most analyses.
We were also missing actual mu files for data22 and data23.
Details about the PRW file can be found in ATLASG-2658.

Cheers,
Bertrand

SUSYTools: add support for MC23d

See merge request !68006

tauRec: minor ConfigFlags cleanup

See merge request !68005