ZDC_SimEvent: Fix cppcheck warnings.

See merge request !68421

TriggerMatchingTool: Fix cppcheck warnings.

See merge request !68420

RPC_Digitization: Fix cppcheck warnings.

See merge request !68422

ZDC_SimuDigitization: Fix cppcheck warnings.

See merge request !68423

MuonGeoModelTestR4: Fix cppcheck warnings.

See merge request !68424

Scott Snyder authored 1 year ago and Adam Edward Barton committed 1 year ago

MuonGeoModelTestR4: Fix cppcheck warnings.

Use CxxUtils::starts_with.

fix typo in WP setup

See merge request !68429

TileByteStream+TrigT2CaloCommon: Read mapping from BS frag ID to Tile drawer ID from DB

See merge request !68316

Siarhei Harkusha authored 1 year ago and Adam Edward Barton committed 1 year ago

TileByteStream+TrigT2CaloCommon: Read mapping from BS frag ID to Tile drawer ID from DB

Tile configuration (CA-based) function to prepare conditions object with mapping
from BS frag ID to Tile drawer ID has been modified to initialize it from DB by default.

This is done to resolve the issue with two Tile modules EBA61 and EBA63 (ROD fibers swapped) in 2022-2023 data.

The conditions algorithm which prepares mapping from BS frag ID to Tile drawer ID
has been modified to use all available information from DB (including beam elements).

Tile ROD decoder tool has been modified to unpack DQ fragment when unpacking channels is requested,
and to use the conditions object with mapping from BS frag ID to Tile drawer ID
as argument in function used to fill Tile cell collection in HLT.

The clients (TrigCaloDataAccessSvc and Tile ROD decoder test) have been updated accordingly.

Prefer preincrement to postincrement for iterator classes.

Useless variables.

Prefer to initialize class members by an initialization list.

Use CxxUtils::starts_with instead of string::find.
Pass objects by const reference rather than by value.

LAr DT monitoring updates

See merge request !68407

Ellis Kay authored 1 year ago and Adam Edward Barton committed 1 year ago

LAr DT monitoring updates

Fix Tile data overlay configuration (ATLASSIM-7041)

See merge request !68379

Siarhei Harkusha authored 1 year ago and Adam Edward Barton committed 1 year ago

Fix Tile data overlay configuration (ATLASSIM-7041)

Legacy data overlay configuration has been updated to use
Tile raw data reading algorithm to read Tile raw data from BS.

Tile digits maker CA-based configuration has been updated
to avoid using SGInputLoader to read Tile digits because
they are read by Tile raw data reading algorithm.

MuonR4 data preparation - Add Tgc & Rpc strip hit conversion from Sim hits  & misc

See merge request !68350

Johannes Junggeburth authored 1 year ago and Adam Edward Barton committed 1 year ago

MuonR4 data preparation - Add Tgc & Rpc strip hit conversion from Sim hits  & misc

Split vx_n_vs_mu plots in CampaignsARTTests

See merge request !68400

Thomas Strebler authored 1 year ago and Adam Edward Barton committed 1 year ago

Split vx_n_vs_mu plots in CampaignsARTTests

Update ISF_Validation tests (part 4: cosmics simulation)

See merge request !49890

John Derek Chapman authored 1 year ago and Adam Edward Barton committed 1 year ago

Update ISF_Validation tests (part 4: cosmics simulation)

TrigPrescalesAlg: Add option for prescale based on trigger formula

See merge request !68373

Filip Nechansky authored 1 year ago and Adam Edward Barton committed 1 year ago

TrigPrescalesAlg: Add option for prescale based on trigger formula

The trigger option in the prw tool can be a formula (trigA||trigB):
https://gitlab.cern.ch/ATLAS-EGamma/athena/-/blob/main/PhysicsAnalysis/AnalysisCommon/PileupReweighting/Root/PileupReweightingTool.cxx#L484
but current implementation of the alg is not intended for this use
and  would result in decoration:
`m_prescaleDecoration+triger_formula` which can lead to problems
because of `||`, spaces and such (not sure decorators allow it?).

This MR would change it that instead of passing list of triggers
one can pass them as `trigFormula` and the decoration would be only
`m_prescaleDecoration`, so it would be much more straighforward to use.

Taking advantage of existing implementation so the execute
part does not change, only the init.

Parameterizing the cluster splitting based on truth value

See merge request !68356

Amir Azzam authored 1 year ago and Adam Edward Barton committed 1 year ago

Parameterizing the cluster splitting based on truth value

AthenaPoolMultiTest: Cleanup EventTag tests

See merge request !68377

Alaettin Serhan Mete authored 1 year ago and Adam Edward Barton committed 1 year ago

AthenaPoolMultiTest: Cleanup EventTag tests

MET: Do not use global config flags

See merge request !68404

[ATR-28717] Initial refactor of trigger EDM toward R4

See merge request !68370

Tim Martin authored 1 year ago and Adam Edward Barton committed 1 year ago

[ATR-28717] Initial refactor of trigger EDM toward R4

HI: Do not use global config flags

See merge request !68403

Taus: Fixes to flags usage

See merge request !68402

Removal of legacy EM triggers - ATR-28612

See merge request !68329

John Patrick Mc Gowan authored 1 year ago and Adam Edward Barton committed 1 year ago

Removal of legacy EM triggers - ATR-28612

Allow mtj and track backends Handles Prefix to be settable in jo

See merge request !68387