InDetTrackPerfMon: Adding TrackAnalysisPlotsMgr and TrackParametersPlots

See merge request !71403

Marco Aparo authored 10 months ago and Tadej Novak committed 10 months ago

InDetTrackPerfMon: Adding TrackAnalysisPlotsMgr and TrackParametersPlots

Add GEOMODEL_INCLUDE_DIRS to include search path for packages depending on GeoModel.

See merge request !71406

Joseph Boudreau authored 10 months ago and Tadej Novak committed 10 months ago

CMakeLists.txt files have been updated for all instances which depend
on the GeoModel core libraries but which do not explicitely include
${GEOMODEL_INCLUDE_DIRS}.  Without this we are in danger of mixing
header files from two sources, and this is actually now happening in
the GeoModel early fault detection pipeline.

2024-05-16: merge of 24.0 into main

See merge request !71424

PyJobTransform: fix running asetup in sub-steps

Closes ATR-29401

See merge request !71430

Compress ACTS CI tests that check the ACTS workflows

See merge request !71428

Carlo Varni authored 10 months ago and Tadej Novak committed 10 months ago

Compress ACTS CI tests that check the ACTS workflows

Reduce number of events for validation workflows.

See merge request !71432

Carlo Varni authored 10 months ago and Tadej Novak committed 10 months ago

Reduce number of events for validation workflows.

Drop unused concept of shared child particle barcodes

See merge request !71362

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

Drop unused concept of shared child particle barcodes

Fix residual problems introduced by !71368. Always use `setupATLAS` to
setup the asetup environment. Also fix and improve text on how to re-run
container-based step locally.

Closes ATR-29401.

main-coverity-LArCalibUtils

See merge request !71408

Shaun Roe authored 10 months ago and Tadej Novak committed 10 months ago

main-coverity-LArCalibUtils

TrkEventCnvTools: Fix naming for MuonEventCnvToolCfg

See merge request !71405

Edward Moyse authored 10 months ago and Tadej Novak committed 10 months ago

TrkEventCnvTools: Fix naming for MuonEventCnvToolCfg

CaloUtils: Add ToolWithConstants::toolType().

See merge request atlas/athena!71413

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

CaloUtils: Add ToolWithConstants::toolType().

A saved set of constants includes both the C++ class name and
a version number.  Normally, the class name is taken from the
Gaudi type() method, but that may be changed by overriding
the toolType() method.  This can be used, for example, when there are
tools with distinct C++ classes but which are yet similar enough
to combine together.

DataModelTestDataCommon: Use AUXVAR_DECL.

See merge request atlas/athena!71420

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

DataModelTestDataCommon: Use AUXVAR_DECL.

Use AUXVAR_DECL macro to register aux variables.

CaloRec: Fix for writing correction constanta to pool.

See merge request !71414

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

CaloRec: Fix for writing correction constanta to pool.

In CaloClusterCorrDBWriter::execute, make sure that the detector store
has been created.  We'll need it during finalize().

CaloD3PDMaker: Fix configuration of CaloNoiseCondAlg.

See merge request atlas/athena!71417

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

CaloD3PDMaker: Fix configuration of CaloNoiseCondAlg.

The configuration of CaloNoiseCondAlg wasn't fully migrated to CA.

ZdcRec: Fix cppcheck warnings.

See merge request atlas/athena!71421

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ZdcRec: Fix cppcheck warnings.

Prefer passing strings by const reference.

ParticleJetTools: Fix cppcheck 2.14 warnings.

See merge request !71422

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ParticleJetTools: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

EFTrackingEmulation: Fix cppcheck warnings.

See merge request !71423

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

EFTrackingEmulation: Fix cppcheck warnings.

Prefer to initialize class members in an initialization list.
Redundant string conversion.

AthLinks: Implement thin() for GenericElementLinkBase.

See merge request atlas/athena!71415

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

AthLinks: Implement thin() for GenericElementLinkBase.

This way, all ELs will have a thin() method.
If thinning can't actually be supported (the index is not integral for example)
then we give a runtime error.  thin() should not actually be called in those
cases, but it's needed for the compilation of some virtual functions.

Also update ElementLink documentation to say that thin() is required of the
base class, and add a proper test for ElementLinkBase::thin().