DerivationFrameworkBPhys+xAODBPhys: Lock decorations from Select_onia2mumu.

See merge request !76956

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

DerivationFrameworkBPhys: Lock decorations from Select_onia2mumu.

Need to make sure that decorations are locked after they are produced.
See ATLASRECTS-8008.

VrtSecInclusive: Don't try to catch exceptions.

See merge request !76960

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

VrtSecInclusive: Don't try to catch exceptions.
    
That just hides problems and makes them more difficult to diagnose.

FlavorTagDiscriminants: Missed reporting some decorations.

See merge request !76958

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

FlavorTagDiscriminants: Missed reporting some decorations.

Fixing unlocked decorations.
See ATLASRECTS-8008.

MuonCondAlg: Protect against unknown MDT station.

See merge request !76925

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

MuonCondAlg: Protect against unknown MDT station.

In MuonAlignmentCondAlg, skip lines from the JSON blob that don't
translate to a valid identifier.

In the test_bulkProcessing_splashes art test, we were getting EIS stations
from the JSON blob, while they didn't exist in the detector description.
The code was trying to convert the resulting (invalid) identifier
to a string for a diagnostic.  Recent Identifier changes resulted
in this crashing with an out-of-bounds exception.  Now handle
this by printing a warning.

Note that this test was already printing warnings like::

```
  MGM::MuonDetectorManager                               0     0 WARNING BLinePar with AmdbId Muon B-Line deformation AMDB id (name,eta,phi,job)=(EIL,-3,2,0),  tube bow in plane bz=0.032, tube bow out of plane bp=0, bn=0, cross plate sage out of plane sp=0, sn=0, twist tw=0, parallelogram pg=0, trapezoid tz=0, global expansion eg=0.085, local expansion ep=0.002, en=-0.001 *** No MuonStation found 
 PLEASE CHECK FOR possible MISMATCHES between alignment constants from COOL and Geometry Layout in use
```

so there may still be a problem with the conditions tag.
Regardless, though, we shouldn't die with an out-of-bounds exception.

ZdcAnalysis: Fix compiling with clang.

See merge request !76964

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

ZdcAnalysis: Fix compiling with clang.

Avoid narrowing conversions in initialization.
Binding references to temporaries in range-for.

DerivationFrameworkPhys+DerivationFrameworkLLP: Avoid overwriting decorations.

See merge request !76968

Scott Snyder authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

DerivationFrameworkPhys: Avoid overwriting decorations.

LLP1 was configuring IsoCloseByCorrectionAlg with non-LRT containers
as well as LRT ones.  But PHYS also configures this algorithm with
non-LRT containers, so if they were used together, then decorations
would get overwritten.  This causes problems then when we want to ensure
that the decorations get locked.

Split the configuration here into two algorithms, the first being identical
to PHYS and the second with the LRT containers.  When PHYS and LLP1 are
used together, then then first algorithm will be merged with the one
from PHYS and we avoid overwrites.

This can result in changes in the decorations for non-LRT containers
in the case that PHYS and LLP1 are used together, due to the differing
track selectors that are used.

CITEST for Global Monitoring

See merge request !75920

Salah-Eddine Dahbi authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

CITEST for Global Monitoring

ATR-30631: MET MC Menu Legacy cleanup

See merge request !76922

ATR-30632: Calib and Streamers MC Menu Legacy cleanup

See merge request !76823

Dvij Mankad authored 3 months ago and Jiri Masik committed 3 months ago

ATR-30632: Calib and Streamers MC Menu Legacy cleanup

LArSuperCellMon/LArRawSCDataReadingConfig scheduling ByteStreamCnvSvc at wrong moments.

See merge request !76902

Denis Oliveira Damazio authored 3 months ago and Jiri Masik committed 3 months ago

LArSuperCellMon/LArRawSCDataReadingConfig scheduling ByteStreamCnvSvc at wrong moments.

Bugfix for BIS78 RPC Bytestream converter

See merge request !76908

Matteo Negrini authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

Bugfix for BIS78 RPC Bytestream converter

Split cfg of LAr HV Cabling into separate config-file

See merge request !76873

Walter Lampl authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

Split cfg of LAr HV Cabling into separate config-file

Projects: Update to LCG_106b_ATLAS_1, atlasexternals 2.1.16.3 and tdaq/tdaq-common 12-00-00

See merge request !76870

John Derek Chapman authored 3 months ago and Duc Ta committed 3 months ago

Projects: Update to LCG_106b_ATLAS_1, atlasexternals 2.1.16.3 and tdaq/tdaq-common 12-00-00

Update the 24.0 branch to LCG_106b_ATLAS_1, atlasexternals 2.1.16.3 and tdaq/tdaq-common 12-00-00.
The most significant updates in LCG_106b (SPI-2678) are ROOT 6.32/08 and xrootd 5.7.2.
The other package updates are listed at: https://lcginfo.cern.ch/compare_releases/None/106b/106a
The layer LCG_106b_ATLAS_1 is identical to LCG_106a_ATLAS_7 apart from the LCG_106b updates.

ATR-30401 - A Prescaled CR Sideband for ATR-28563 A Phase I L1Topo LLP Trigger

See merge request !76833

Francesco Curcio authored 3 months ago and Jiri Masik committed 3 months ago

Revert "removed unnecessary per-bit addvariable"

This reverts commit da22d1e2.

ATR-30628 ATR-30627 request clean-up for legacy chains

See merge request !76834

Zhongyukun Xu authored 3 months ago and Jiri Masik committed 3 months ago

ATR-30628 ATR-30627 request clean-up for legacy chains

Anomaly trigger dummy implementation

See merge request !76182

Sagar Addepalli authored 3 months ago and Jiri Masik committed 3 months ago

Anomaly trigger implementation

Anomaly trigger implementation

update naming based on recommendation

ZdcMonitoring: Fix clang warnings.

See merge request !76860

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

ZdcMonitoring: Fix clang warnings.

Binding temporaries to references in range-for.

SCT_Digitization: Fix out-of-bounds vector writes.

See merge request !76859

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

SCT_Digitization: Fix out-of-bounds vector writes.

reserve/resize mixup

TileConditions: Fix array bounds checking.

See merge request !76856

Scott Snyder authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

TileConditions: Fix array bounds checking.

Fix off-by-one errors in array bounds checks.
Solves crashes seen when building with -D_GLIBCXX_ASSERTIONS.