Christos Anastopoulos authored 10 months ago and Adam Edward Barton committed 10 months ago

ATLASRECTS-7987: Identation fixes per request of shifter

Walter Lampl authored 10 months ago and Duc Ta committed 10 months ago

LArLATOMEBuilderAlg: Property use data-pool

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

Put GeoModel libs first in the Cmake lists

Revert align store

Pass strings by const reference, not by value.

Joseph Boudreau authored 10 months ago and Tadej Novak committed 10 months ago

CMakeLists.txt files have been updated for all instances which depend
on the GeoModel core libraries but which do not explicitely include
${GEOMODEL_INCLUDE_DIRS}.  Without this we are in danger of mixing
header files from two sources, and this is actually now happening in
the GeoModel early fault detection pipeline.

Shaun Roe authored 10 months ago and Tadej Novak committed 10 months ago

main-coverity-LArCalibUtils

Walter Lampl authored 10 months ago and Duc Ta committed 10 months ago

use unorderd map for LArLATOMEMapping

Thomas Strebler authored 10 months ago and Ahmed Tarek committed 10 months ago

Clean up legacy LArAlignmentAlgs configs

Ellis Kay authored 10 months ago and Marija Vranjes Milosavljevic committed 10 months ago

Change LAr baseline monitoring plots so we check adc[0]-ped instead of adc-ped for all samples

Pavol Strizenec authored 10 months ago and Duc Ta committed 10 months ago

LAr SC patching fixes

Attila Krasznahorkay authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Made all binaries that depend on LTO, use LTO themselves as well.

Also, moved MuonSensitiveDetectorsR4 into AtlasGeant4.

Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArSC2NtupleEB: fixed clang warning

Use std::abs for integers

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArCalibUtils: Fix cppcheck warning.

Pass container by const reference, not by value.

Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Fixed clang warnings

Removed unused private data members. Plus minor code cleanup.
Affected packages
- `ForwardDetectors/ZDC/ZdcAnalysis`
- `LArCalorimeter/LArCOOLConditions`

Ellis Kay authored 10 months ago and Tim Martin committed 10 months ago

LAr DT mon fixes, addressing https://its.cern.ch/jira/browse/ATLASRECTS-7976

Pavol Strizenec authored 10 months ago and Duc Ta committed 10 months ago

Add SC postprocessing

Shaun Roe authored 10 months ago and Johannes Elmsheuser committed 10 months ago

main-coverity-LArL1Sim

Walter Lampl authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArStripsCrossTalkCorrector: Profit from C++20 std::to_array

Walter Lampl authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArMonAlgs: std::to_array

Pavol Strizenec authored 10 months ago and Jiri Masik committed 10 months ago

LAr and Calo DB fixes for new COOL proxy

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArG4FastSimulation: Fix cppcheck warnings.

Delete copy/assignment for class that manages memory.

Walter Lampl authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArBadFeb2Ascii: Use std::format, eliminate constructor

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArG4EC: Fix cppcheck warning.

Suppress cppcheck false positive.

LArBadChannel dumper: Use std::format

Benjamin Morgan authored 10 months ago and Walter Lampl committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

This reverts commit 9b36ad1f, reversing
changes made to 4d2926b2.

Walter Lampl authored 11 months ago and Duc Ta committed 11 months ago

add test to verify LAr online/offline identifier consistency

Benjamin Morgan authored 11 months ago and Duc Ta committed 11 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Thomas Strebler authored 11 months ago and Ahmed Tarek committed 11 months ago

Clean up legacy LArBadChannelTool configs