Instead of returning `None`, which would be considered an equal hash,
throw an exception when trying to hash an unlocked `AthConfigFlags`
container.

This avoids false accumulator caching in case someone forgets to lock
the flag container. Mostly an issue for unit tests and mixed
old/new-style job options.

Also simplify the hash calculation by only invoking `hash` once.

- rename `TestAthConfigFlags.py` to lower-case to follow convention used
  in other files in this package
- cleanup the unit test definition, i.e. use the auto-discovery for test
  functions to avoid accidentally not enabling new tests

Teach `OldFlags2NewFlags` to handle HITS input via
`AthenaCommonFlags.PoolHitsInput` as well.

Also give `FilesInput` higher priority in all cases.

For unit testing, it is often useful to be able to re-create the
`ConfigFlags` from scratch to be able to test with different settings
(e.g. different input files). This can now be done via:
```
from AthenaConfiguration.AllConfigFlags import _createCfgFlags
ConfigFlags = _createCfgFlags()
```

Fix missing imports in `OldFlags2NewFlags` and add a unit test.

Also increase the timeout for a test that was seen to be timing out
in a debug build.

Fix these type of warnings
```
Py:conf2toConfigurable WARNING Component: "" is of type string, no conversion, some properties possibly not set?
```
that appear when trying to convert an empty `ToolHandle` property. This
is a valid use-case and we should not be warning about that.

Also fix some of the debug message text and indentation.

Also add proposed Run-4 entry

Ewelina Maria Lobodzinska authored 3 years ago and Atlas Nightlybuild committed 3 years ago

Adding some more config_only checks in MadGraphControl

See merge request atlas/athena!44915

(cherry picked from commit 0a661e2c)

63baa220 Adding some more config_only checks in MadGraphControl
ac994868 Typo in a comment

Ewelina Maria Lobodzinska authored 3 years ago and Atlas Nightlybuild committed 3 years ago

add note about ME-only weights

See merge request atlas/athena!44967

(cherry picked from commit d8bff24a)

867a95d2 add note about ME-only weights
c16309f1 fix typos
cf6048f5 fix typos

The hash value returned by -athHash- determines if the
value of a function can be cached and memoized. This
change fixes a problem caused by introducing the
-id- function into hash calculation.

Tests:

Test project /afs/cern.ch/user/k/ktopolni/private/git_tutorial_15_03_2020/build
      Start  1: AthenaCommon_AthAppMgrUnitTests_ctest
      Start  2: AthenaCommon_ConfigurableUnitTests_ctest
      Start  3: AthenaCommon_JobOptionsUnitTests_ctest
 1/40 Test  #2: AthenaCommon_ConfigurableUnitTests_ctest .................   Passed    4.43 sec
      Start  4: AthenaCommon_JobPropertiesUnitTests_ctest
 2/40 Test  #4: AthenaCommon_JobPropertiesUnitTests_ctest ................   Passed    1.07 sec
      Start  5: AthenaCommon_KeyStoreUnitTests_ctest
 3/40 Test  #5: AthenaCommon_KeyStoreUnitTests_ctest .....................   Passed    1.57 sec
      Start  6: AthenaCommon_CFElementsTest_ctest
 4/40 Test  #6: AthenaCommon_CFElementsTest_ctest ........................   Passed    1.25 sec
      Start  7: AthenaConfiguration_AthConfigFlagsTest_ctest
 5/40 Test  #7: AthenaConfiguration_AthConfigFlagsTest_ctest .............   Passed    0.58 sec
      Start  8: AthenaConfiguration_MainServicesConfig_ctest
 6/40 Test  #8: AthenaConfiguration_MainServicesConfig_ctest .............   Passed    1.00 sec
      Start  9: AthenaConfiguration_testAccumulatorCache_ctest
 7/40 Test  #9: AthenaConfiguration_testAccumulatorCache_ctest ...........   Passed    0.61 sec
      Start 10: AthenaConfiguration_ComponentAccumulatorTest_ctest
 8/40 Test #10: AthenaConfiguration_ComponentAccumulatorTest_ctest .......   Passed    1.65 sec
      Start 11: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest
 9/40 Test #11: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest ...   Passed    5.19 sec
      Start 12: AthenaConfiguration_DetectorConfigFlags_test_ctest
10/40 Test  #1: AthenaCommon_AthAppMgrUnitTests_ctest ....................   Passed   17.42 sec
      Start 13: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest
11/40 Test  #3: AthenaCommon_JobOptionsUnitTests_ctest ...................   Passed   17.41 sec
      Start 14: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest
12/40 Test #12: AthenaConfiguration_DetectorConfigFlags_test_ctest .......   Passed    1.69 sec
      Start 15: AthenaConfiguration_AllConfigFlagsTest_ctest
13/40 Test #13: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest ...   Passed    5.63 sec
      Start 16: AthenaConfiguration_ComponentAccumulatorTestReco_ctest
14/40 Test #16: AthenaConfiguration_ComponentAccumulatorTestReco_ctest ...   Passed    1.01 sec
      Start 17: AthenaMonitoring_ExampleMonitorAlgorithm_test_ctest
15/40 Test #14: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest ....   Passed   16.42 sec
      Start 18: TrigT2CaloCommon_TestService_ctest
16/40 Test #17: AthenaMonitoring_ExampleMonitorAlgorithm_test_ctest ......   Passed   53.03 sec
      Start 19: TrigT2CaloCommon_TestServiceNewJO_ctest
17/40 Test #18: TrigT2CaloCommon_TestService_ctest .......................   Passed   43.36 sec
      Start 20: TrigT2CaloCommon_caloOnly_ctest
18/40 Test #20: TrigT2CaloCommon_caloOnly_ctest ..........................   Passed    0.12 sec
      Start 21: TrigT2CaloCommon_caloRinger_ctest
19/40 Test #21: TrigT2CaloCommon_caloRinger_ctest ........................   Passed    0.13 sec
      Start 22: TrigConfigSvc_AccumulatorTest_ctest
20/40 Test #22: TrigConfigSvc_AccumulatorTest_ctest ......................   Passed    1.49 sec
      Start 23: TrigConfigSvc_FrontierTest_ctest
21/40 Test #23: TrigConfigSvc_FrontierTest_ctest .........................   Passed    3.97 sec
      Start 24: TrigInDetConfig_trigInDetFastTrackingCfg_ctest
22/40 Test #15: AthenaConfiguration_AllConfigFlagsTest_ctest .............   Passed   66.60 sec
      Start 25: TrigInDetConfig_TrigTrackingCutFlags_ctest
23/40 Test #25: TrigInDetConfig_TrigTrackingCutFlags_ctest ...............   Passed    3.84 sec
      Start 26: TriggerTest_TrigValSteeringUT_ctest
24/40 Test #24: TrigInDetConfig_trigInDetFastTrackingCfg_ctest ...........   Passed   10.94 sec
      Start 27: TriggerMenuMT_generateMenuMT_newJO_ctest
25/40 Test #19: TrigT2CaloCommon_TestServiceNewJO_ctest ..................   Passed   22.53 sec
      Start 28: TriggerMenuMT_generateMenuMT_ctest
26/40 Test #26: TriggerTest_TrigValSteeringUT_ctest ......................   Passed   46.08 sec
      Start 29: TriggerMenuMT_full_menu_cf_ctest
27/40 Test #29: TriggerMenuMT_full_menu_cf_ctest .........................   Passed   59.76 sec
      Start 30: TriggerMenuMT_ViewCFTest_ctest
28/40 Test #30: TriggerMenuMT_ViewCFTest_ctest ...........................   Passed    1.04 sec
      Start 31: TriggerMenuMT_EventBuildingSequences_ctest
29/40 Test #31: TriggerMenuMT_EventBuildingSequences_ctest ...............   Passed    1.28 sec
      Start 32: TriggerMenuMT_checkMenuPrimaries_ctest
30/40 Test #32: TriggerMenuMT_checkMenuPrimaries_ctest ...................   Passed    6.28 sec
      Start 33: TriggerMenuMT_RecoFragmentsPool_ctest
31/40 Test #33: TriggerMenuMT_RecoFragmentsPool_ctest ....................   Passed    0.98 sec
      Start 34: TriggerMenuMT_L1_LS2_v1_ctest
32/40 Test #34: TriggerMenuMT_L1_LS2_v1_ctest ............................   Passed    1.38 sec
      Start 35: TriggerMenuMT_L1_Physics_pp_run3_v1_ctest
33/40 Test #35: TriggerMenuMT_L1_Physics_pp_run3_v1_ctest ................   Passed    1.31 sec
      Start 36: TriggerMenuMT_L1_PhysicsP1_pp_run3_v1_ctest
34/40 Test #36: TriggerMenuMT_L1_PhysicsP1_pp_run3_v1_ctest ..............   Passed    1.54 sec
      Start 37: TriggerMenuMT_L1_MC_pp_run3_v1_ctest
35/40 Test #37: TriggerMenuMT_L1_MC_pp_run3_v1_ctest .....................   Passed    1.36 sec
      Start 38: TriggerMenuMT_L1_Cosmic_run3_v1_ctest
36/40 Test #38: TriggerMenuMT_L1_Cosmic_run3_v1_ctest ....................   Passed    1.42 sec
      Start 39: TriggerMenuMT_L1_PhysicsP1_HI_run3_v1_ctest
37/40 Test #39: TriggerMenuMT_L1_PhysicsP1_HI_run3_v1_ctest ..............   Passed    1.40 sec
      Start 40: TriggerMenuMT_L1_Dev_HI_run3_v1_ctest
38/40 Test #40: TriggerMenuMT_L1_Dev_HI_run3_v1_ctest ....................   Passed    1.48 sec
39/40 Test #28: TriggerMenuMT_generateMenuMT_ctest .......................   Passed  129.26 sec
40/40 Test #27: TriggerMenuMT_generateMenuMT_newJO_ctest .................   Passed  204.46 sec

100% tests passed, 0 tests failed out of 40

Label Time Summary:
AthenaCommon           =  43.14 sec*proc (6 tests)
AthenaConfiguration    = 100.38 sec*proc (10 tests)
AthenaMonitoring       =  53.03 sec*proc (1 test)
TrigConfigSvc          =   5.46 sec*proc (2 tests)
TrigInDetConfig        =  14.79 sec*proc (2 tests)
TrigT2CaloCommon       =  66.13 sec*proc (4 tests)
TriggerMenuMT          = 412.95 sec*proc (14 tests)
TriggerTest            =  46.08 sec*proc (1 test)

Total Test time (real) = 298.40 sec

Adjust to new BootstrapHelper interface.