Carlo Varni authored 9 months ago and Frank Winklmeier committed 9 months ago

always do acts clusters and disable pixel for sp and seed for LRT

TrkGlobalChi2Fitter: Fix handling of bad fits.

See merge request !71460

Disable `refitSeeds` by default

See merge request !71683

Move the documentation from  packagedoc headers to README.md for Generators

See merge request !71682

Andrii Verbytskyi authored 10 months ago and Adam Edward Barton committed 10 months ago

Move the documentation from  packagedoc headers to README.md for Generators

In GlobalChi2Fitter::calculateTrackParameters, we propagate track parameters
along the track from one measurement on a track to another.
The track parameters are also assocated with a surface.
After the propagation we store the parameters in the GXFTrajectory
along with a measurement.  Later, there will be an assertion that the
surface of the parameter matches the surface of the measurement.

There is, however, a maximum path length for the propagation, which is usually
set to a hard-coded length of 10m.  Once this length is reached, we stop
and return a CurvilinearParameters object a dummy surface corresponding
to the point at which the propagation stopped.  But if we store this result
in GXFTrajectory, then we can fail later with an assertion
in TrackStateOnSurface.

We can exceed the maximum path length in cases where the fit is unstable.

Detect cases where the assertion in TrackStateOnSurface would fail and
instead treat as a failed fit.
Fixes test failure seen in ActsConfig in the dbg build.

TrackRecordGenerator: Set attributes of particle after the particle is added to event

See merge request !71668

Andrii Verbytskyi authored 10 months ago and Adam Edward Barton committed 10 months ago

TrackRecordGenerator: Set attributes of particle after the particle is added to event

Remove unnecessary private method from ACTS pixel Clustering tool

See merge request !71670

main-cppcheck-ZdcNtuple

See merge request !71666

Move the only c++ code from GeneratorUtils to CXXUtils

See merge request !71661

Andrii Verbytskyi authored 10 months ago and Adam Edward Barton committed 10 months ago

Move the only c++ code from GeneratorUtils to CXXUtils

More informative info in case of FPEs

See merge request !71644

Carlo Varni authored 10 months ago and Adam Edward Barton committed 10 months ago

More informative info in case of FPEs

main-remove_test-ActsEvent

See merge request !71667

AthenaPython: Add missing PyGILStateEnsure.

See merge request !71650

FTagAnalysisAlgorithms: Fix discovery of unit tests.

See merge request !71651

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

FTagAnalysisAlgorithms: Fix discovery of unit tests.

Need to specify a pattern for unit test discovery --- the default won't match
anything.  Fixes a failure seen with python 3.12, where unittest will fail
if it doesn't find any tests.

MuonTrackPerformance+MuonCombinedTrackFindingTools: Use Accessor, etc instead of auxdata().

See merge request !71653

TrkAlignGenTools+AnalysisTriggerAlgs: Fix cppcheck warnings.

See merge request !71655

GSFFindIndexOfMinimum : Documentation fixes

See merge request !71656

starts_with.h fix some comments

See merge request !71662

Christos Anastopoulos authored 10 months ago and Adam Edward Barton committed 10 months ago

starts_with.h fix some comments

StoreGateTests: Increase test timeout.

See merge request !71652

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

StoreGateTests: Increase test timeout.

Increase timeout for test which has been timing out frequently in some builds.

FPGATrackSimFitConstantBank: silenced clang warning

See merge request !71660

TrigEgammaMatchingTool+TrigAFPHypo: Fix cppcheck warnings.

See merge request !71657

TrigMuonMonitoring: Fix cppcheck warnings.

See merge request !71658

Scott Snyder authored 10 months ago and Adam Edward Barton committed 10 months ago

TrigMuonMonitoring: Fix cppcheck warnings.

Pass strings by const reference, not by value.
Fix use of string::find().

MuonR4 - Fix MM digitization in the stereo layers

See merge request !71623

Johannes Junggeburth authored 10 months ago and Adam Edward Barton committed 10 months ago

MuonR4 - Fix MM digitization in the stereo layers

Simplifying HitNtuple for Hough transform

See merge request !70434

Siyuan Yan authored 10 months ago and Adam Edward Barton committed 10 months ago

The Master said: To have faults and not to reform them - this, indeed, should be pronounced having faults.

LArLATOMEDecoder: Use unique_ptr instead of hand-crafted new/delete

See merge request !71637

Fix for ATLINFR-5383 : only check for files for DiffPool

Closes ATLINFR-5383

See merge request !71664

Edward Moyse authored 10 months ago and Adam Edward Barton committed 10 months ago

Fix for ATLINFR-5383 : only check for files for DiffPool