Scott Snyder authored 1 year ago and Frank Winklmeier committed 1 year ago

AthenaDBTestRec: Fix cppcheck warnings.

Pass strings by const reference, not by value.

Christos Anastopoulos authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Trk::Track : Hold the TrackStates as ptr rather than value. Otherwise we lose the DV polymorphic behaviour

Trk::Track : Hold the TrackStates as ptr rather than value. Otherwise we lose (splice) the DV polymorphic behaviour

Make unit tests less sensitive to changes in DEBUG messages

Make the LArCellCont unit tests less sensitive to DEBUG message changes
by running them as INFO. Also suppress the new "data pedendencies" DEBUG
message for all other tests.

This job option script was just forwarding the include to
CaloConditions/CaloConditions_jobOptions.py. Dropped the obsolete
script and fixed all its clients.

This is yet another step towards dropping the CaloDetMgrDetDescrCnv package

Christos Anastopoulos authored 2 years ago and Tadej Novak committed 2 years ago

Trk::Track pass FitQuality as unique_ptr since we keep it as such

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

CompetingRIO keep vector rather than ptr to vector

Christos Anastopoulos authored 2 years ago and Tadej Novak committed 2 years ago

TSOS: keep FitQualityOnsurface as value. Re-organise constructors

EventInfoMgt: thread-checker cleanup

Remove redundant thread-checker annotations (the whole package is being
checked now). Also cleanup link dependencies.

Remove (unused) dependency on the old EventInfo package.

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

AthenaPoolMultiTest: Fix cppcheck warning.

Redundant null check.

Marcin Nowak authored 2 years ago and Julien Maurer committed 2 years ago

Remove IOV Callback from TagInfoMgr

Removed the use of the IOVSvc callback as it is not thread-safe.
Now relying solely on incidents (begin run/file)
Also removed DataHandles use to not trigger gccchecker thread safety
errors (see ATEAM-855)

John Derek Chapman authored 2 years ago and Julien Maurer committed 2 years ago

TileByteStream: Fix test configuration.

Update for changes in tile configuration: need to disable Geant4 version check.
Update reference files.
Fixes test failure in master.

Fix another ordering issue in the unit tests. Make sure to use the Pool
catalog written by the dependee.

Closes ATEAM-859.

Adam Edward Barton authored 2 years ago and Atlas Nightlybuild committed 2 years ago

AthenaDBTestRec+AthenaPoolMultiTest: enable thread-checker

See merge request atlas/athena!56540

(cherry picked from commit ab86a0af)

3c9ab245 AthenaPoolMultiTest: enable thread-checker
1c65dccd AthenaDBTestRec: enable thread-checker
dace49e9 AthenaPoolMultiTest: use dedicated POOL catalogue for EventNoSplit test

Use a private working directory for the Overlay tests to avoid
collisions in `PoolCatalogue.xml` with the other tests. Also use private
catalogues for the `DoubleSelector` test.

Avoid chances of POOL catalogue collisions by using a dedicated
PoolCatalogue in the `EventNoSplit` test.

Mostly suppress checker warnings by marking testing classes as not
thread-safe.

Frank Winklmeier authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Cleanup CutFlowSvc configuration a bit

See merge request !56255

(cherry picked from commit f323082f)

f6130257 Cleanup CutFlowSvc configuration a bit

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

IOVDbTestAlg: Enable thread-safety checking.

Enable thread-safety checking and fix warnings.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

AthenaPoolTest: Enable thread-safety checking.

Enable thread-safety checking and fix warnings.

Enable thread-safety checking.

Enable thread-safety checking and fix warnings.

Shaun Roe authored 2 years ago and Adam Edward Barton committed 2 years ago

23.0-cppcheck-AthenaDBTestRec

Migrated two algorithms: EventInfoWriter and EventInfoReader.
Fixed relevant unit tests

Enable thread-safety checking.

Enable thread-safety checking.