Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

Move the Find Index of Minimum code in a separate header . Collect all methods and add a test

STEP covariance contribution can use reference

See merge request !67938

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

STEP covariance contribution can use reference

adding DSID 411316 in HadronOrigin and HF Classifier

See merge request !67941

Linghua Guo authored 1 year ago and Frank Winklmeier committed 1 year ago

adding DSID 411316 in HadronOrigin and HF Classifier

Fix for TLV initialisation for DiTau truth matching

See merge request !67921

Antonio De Maria authored 1 year ago and Frank Winklmeier committed 1 year ago

Fix for TLV initialisation for DiTau truth matching

ParametersCommon : change the syntax for the covariance method so as to be a bit clearer

See merge request !67935

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

ParametersCommon : change the syntax for the covariance method so as to be a bit clearer

Create HGTD script for RDOAnalysis

See merge request atlas/athena!67608

Louis D'Eramo authored 1 year ago and Frank Winklmeier committed 1 year ago

Create HGTD script for RDOAnalysis

Add vany for the vec types

See merge request !67928

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

Add vany for the vec types

ZDC_SimuDigitization: fixed clang warnings

See merge request !67942

TrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX switch matrix.

See merge request !67862

Ondrej Penc authored 1 year ago and Frank Winklmeier committed 1 year ago

TrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX switch matrix.

1. Braces for the initialization of multi-dimensional arrays
2. Unused local variable

CPAlgorithms: config block for IFF classifier

See merge request !67847

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: config block for IFF classifier

Fixes for ATLASRECTS-7864

See merge request !67924

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

Fixes for ATLASRECTS-7864

Some improvments to LArCellBuilderFromLArRawChannelTool

See merge request !67931

Walter Lampl authored 1 year ago and Frank Winklmeier committed 1 year ago

Some improvments to LArCellBuilderFromLArRawChannelTool

Allow an ART test that creates a new directory to be run twice in the same directory

See merge request !67930

Stewart Martin-Haugh authored 1 year ago and Frank Winklmeier committed 1 year ago

Allow an ART test that creates a new directory to be run twice in the same directory

2023-12-19: merge of 23.0 into main

See merge request !67925

HGTDCluster mark as final. use ctors with "move" arguments

See merge request !67908

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

HGTDCluster mark as final. use ctors with "move" arguments

add smearing tool to MM overlay digitizer

Closes ATLASRECTS-7863

See merge request !67905

DerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticles

See merge request !67926

Bertrand Martin Dit Latour authored 1 year ago and Frank Winklmeier committed 1 year ago

DerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticles

Hello,

This MR changes the number of generations of daughter particles retained when building the TruthTausWithDecayParticles/TruthTausWithDecayVertices collections.
It was previously set to 1, but this can lead to pathological situations, e.g. when the truth tau decays to kaons: if we don't know what the kaon decays to, we cannot properly compute the truth visible tau momentum.
When set to -1, we retain all generations, and this seems to fix the problem.

 A priori, we can now recompute the various decorations of TruthTaus using TruthTausWithDecayParticles/TruthTausWithDecayVertices, such as `pt/eta/phi/m_vis`, the number of neutral/charged pions, ...
We will need to rework a bit BuildTruthTaus to do this.
The only variables we don't seem to get is `polarizationPhi` and `polarizationTheta` decorations, they exist for TruthTaus but not TruthTausWithDecayParticles, however these seem to always be 0.
We still need to check we can rerun photon dressing for TruthTausWithDecayParticles.

Marking as urgent as we'd need this for the upcoming DAOD_PHYS production that is imminent.

Cheers,
Bertrand

TrigInDetValidation: drop deprecated preInclude

See merge request !67927

Bertrand Martin Dit Latour authored 1 year ago and Frank Winklmeier committed 1 year ago

TrigInDetValidation: drop deprecated preInclude

Hello,

This MR is cleaning up a leftover from !66815 .

Cheers,
Bertrand

ElectronEfficiencyCorrection : Look for the base name ATLFAST (no 2 or 3)

See merge request !67910

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

ElectronEfficiencyCorrection : Look for the base name ATLFAST (no 2 or 3)

TRT_BaseElement, SolidStateDetectorElementBase : Inline some simple 'final' methods

See merge request !67909

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

TRT_BaseElement, SolidStateDetectorElementBase : Inline some simple 'final' methods that are called quite a bit

added back in call to CloseBy correction which was accidentally removed in MR 67455

See merge request !67923