Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Fixed clang warnings

Removed unused private data members. Plus minor code cleanup.
Affected packages
- `ForwardDetectors/ZDC/ZdcAnalysis`
- `LArCalorimeter/LArCOOLConditions`

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

CaloClusterCorrection+CaloCondPhysAlgs: fix flake8-bugbear warnings

Replace `getattr` with regular attribute access.

Brian Andrew Cole authored 10 months ago and Duc Ta committed 10 months ago

Push updates for 2016 pPb and 2023 PbPb into fresh branch

Benjamin Morgan authored 10 months ago and Walter Lampl committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

This reverts commit 9b36ad1f, reversing
changes made to 4d2926b2.

Benjamin Morgan authored 11 months ago and Duc Ta committed 11 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Andrii Verbytskyi authored 11 months ago and Frank Winklmeier committed 11 months ago

Fix cppcheck warnings

Scott Snyder authored 11 months ago and Frank Winklmeier committed 11 months ago

AFP_Calibration: Fix cppcheck warning.

Copying value in range-for.

Scott Snyder authored 11 months ago and Frank Winklmeier committed 11 months ago

ZdcNtuple: Fix compilation with hepmc2.

Hepmc2 compatibility.

John Derek Chapman authored 11 months ago and Frank Winklmeier committed 11 months ago

Update TruthIncidents and ISFParticle to know about uniqueID

Frank Winklmeier authored 11 months ago and Ahmed Tarek committed 11 months ago

ZdcByteStream: remove legacy job options

Thomas Strebler authored 11 months ago and Ahmed Tarek committed 11 months ago

Clean up more AFP legacy configs

1. ZDC_DetFactory.cxx: unused local variable
2. ActsDetectorElement.cxx: unused lamdba capture

Delete legacy job options that have not been touched in 9 years, which
probably means they were never even used.

Chad Stephen Lantz authored 11 months ago and Ahmed Tarek committed 11 months ago

Merge branch '23.0-ZDC_GeoM-RPD-Foot' into '23.0'

Changed ZDC module placement to allow for the RPD foot

See merge request !69878

Remove references to legacy config and updates link dependencies.

1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variable

Peter Alan Steinberg authored 1 year ago and Duc Ta committed 1 year ago

Adding versioning in ZDC calibration files via parameter for TDirectory name

Pass strings by const reference, not by value.

John Derek Chapman authored 1 year ago and Frank Winklmeier committed 1 year ago

New persistent version of LucidSimHitCollection based on GenParticle::id()