Fang-Ying Tsai authored 9 months ago and Frank Winklmeier committed 9 months ago

Add ATLFAST3F_ACTSMT to G4TransportTool for Multithreaded Simulation

2024-05-24: merge of 24.0 into main

Closes ATR-29380

See merge request !71694

Clean up in the segment making & clusterization

See merge request !71511

Simpliyfy hit clustering

Simplify the Tgc clustering

Clean up more unused tools

Clean uo

Remove includes

Delete Mdt hit clustering

Drop EgammaCovarianceCalculation since suppressed in_AOD

See merge request !71636

TrkGlobalChi2Fitter: Fix handling of bad fits.

See merge request !71460

Disable `refitSeeds` by default

See merge request !71683

Move the documentation from  packagedoc headers to README.md for Generators

See merge request !71682

Andrii Verbytskyi authored 9 months ago and Adam Edward Barton committed 9 months ago

Move the documentation from  packagedoc headers to README.md for Generators

TriggerJobOpts: update forceConditions postExec

See merge request !71675

Bertrand Martin Dit Latour authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

TriggerJobOpts: update forceConditions postExec

Hello,

In some trigger ART tests, we override conditions by forcing the run number and LB, or the timestamp.
This MR is updating the list of timestamp-based trigger condition folders. The existing list seems otherwise up-to-date, except `/TDAQ/Resources/ATLAS/SCT/Robins` which is apparently unused, maybe it was in Run1 or Run2. Fixes ATR-29380.

Cheers,
Bertrand

Chains are moved from the Physics Menu to the MC Menu, ATR-29443

See merge request !71642

Muhammad Alhroob authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

Chains are moved from the Physics Menu to the MC Menu, ATR-29443

pass flags to getTrigEgammaKeys

See merge request !71638

Jiri Masik authored 9 months ago and Dylan Remberto Van Arneman committed 9 months ago

pass flags to getTrigEgammaKeys

AFT-738: Protect against null pointer

See merge request !71645

Dan Guest authored 9 months ago and Duc Ta committed 9 months ago

AFT-738: Protect against null pointer

Modified testing condition, special chain cases treatment implemented

See merge request !71673

Witold Wojciech Przygoda authored 9 months ago and Duc Ta committed 9 months ago

Modified testing condition, special chain cases treatment implemented

In GlobalChi2Fitter::calculateTrackParameters, we propagate track parameters
along the track from one measurement on a track to another.
The track parameters are also assocated with a surface.
After the propagation we store the parameters in the GXFTrajectory
along with a measurement.  Later, there will be an assertion that the
surface of the parameter matches the surface of the measurement.

There is, however, a maximum path length for the propagation, which is usually
set to a hard-coded length of 10m.  Once this length is reached, we stop
and return a CurvilinearParameters object a dummy surface corresponding
to the point at which the propagation stopped.  But if we store this result
in GXFTrajectory, then we can fail later with an assertion
in TrackStateOnSurface.

We can exceed the maximum path length in cases where the fit is unstable.

Detect cases where the assertion in TrackStateOnSurface would fail and
instead treat as a failed fit.
Fixes test failure seen in ActsConfig in the dbg build.

TrackRecordGenerator: Set attributes of particle after the particle is added to event

See merge request !71668

Andrii Verbytskyi authored 9 months ago and Adam Edward Barton committed 9 months ago

TrackRecordGenerator: Set attributes of particle after the particle is added to event

Remove unnecessary private method from ACTS pixel Clustering tool

See merge request !71670

main-cppcheck-ZdcNtuple

See merge request !71666

Move the only c++ code from GeneratorUtils to CXXUtils

See merge request !71661

Andrii Verbytskyi authored 9 months ago and Adam Edward Barton committed 9 months ago

Move the only c++ code from GeneratorUtils to CXXUtils

More informative info in case of FPEs

See merge request !71644

Carlo Varni authored 9 months ago and Adam Edward Barton committed 9 months ago

More informative info in case of FPEs

main-remove_test-ActsEvent

See merge request !71667

AthenaPython: Add missing PyGILStateEnsure.

See merge request !71650

FTagAnalysisAlgorithms: Fix discovery of unit tests.

See merge request !71651

Scott Snyder authored 9 months ago and Adam Edward Barton committed 9 months ago

FTagAnalysisAlgorithms: Fix discovery of unit tests.

Need to specify a pattern for unit test discovery --- the default won't match
anything.  Fixes a failure seen with python 3.12, where unittest will fail
if it doesn't find any tests.

MuonTrackPerformance+MuonCombinedTrackFindingTools: Use Accessor, etc instead of auxdata().

See merge request !71653

TrkAlignGenTools+AnalysisTriggerAlgs: Fix cppcheck warnings.

See merge request !71655