Resolve cppcheck defects in TopAnalysis code

See merge request !68086

AthContainers: Refactor to avoid circular dependency.

See merge request atlas/athena!68050

make ROOTTREE default storage for metadata instead of ROOTTREEINDEX

See merge request !67972

Maciej Pawel Szymanski authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

make ROOTTREE default storage for metadata instead of ROOTTREEINDEX

Fix regression issues in test_AtlasG4_CalibationHits_pions_MT.sh ART script (ATLASSIM-6968)

Closes ATLASSIM-6968

See merge request !68087

MuonMDT_Cabling: Fix cppcheck warning.

See merge request atlas/athena!68066

TRT_ReadoutGeometry+PixelReadoutGeometry: Fix cppcheck warnings.

See merge request atlas/athena!68067

EventIndexProducer: Increase test timeouts.

See merge request !68061

Work around false positive null pointer dereference warning.

Avoid false positive warning about null pointer dereference.

Redundant string conversion.

TileMonitoring: Fix gcc14 warnings.

See merge request atlas/athena!68060

LArGMConfigTest: Do not use global instance of config flags and explicitly set geometry version

See merge request atlas/athena!68053

LAr: Do not use global instance of config flags and explicitly set geometry version

See merge request !68054

Muon configuration: explicitly set geometry tag in tests

See merge request !68055

Tests have been timing out in dbg build.

Adding misalignment to the global frame with additional radial shift of SCT endcap considered

See merge request atlas/athena!67789

Xilin Wang authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Adding misalignment to the global frame with additional radial shift of SCT endcap considered

cleaning DiTau reconstruction

See merge request atlas/athena!67990

Antonio De Maria authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

cleaning DiTau reconstruction

Bug fix on ​L2MuonSAIOMon in TrigMuonMonitoring

See merge request !67980

Ryo Ishikawa authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

test_q442_mp.sh: Add --CA

test_q442_mp.sh: Add --CA

Adjust AFP vertex reconstruction to input given by nano instead of pico seconds

See merge request atlas/athena!67977

Leszek Adamczyk authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Adjust AFP vertex reconstruction to input given by nano instead of pico seconds

CxxUtils:Vec. Expand the Bool reductions adding all,none on top of any. Plus tests

See merge request atlas/athena!67989

Christos Anastopoulos authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

CxxUtils:Vec. Expand the Bool reductions adding all,none on top of any. Plus tests

Renamed ActsTrk::TrackStorageContainer to ActsTrk::TrackSummaryContainer

Closes ATLIDTRKCP-513

See merge request atlas/athena!67999

Unused typedefs.

BTagging clean up

See merge request atlas/athena!68025

Thomas Strebler authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

BTagging clean up

TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone

See merge request !67904

Bertrand Martin Dit Latour authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone

Hello,

When running RDOtoRDOTrigger with the legacy config, it seems that we do not set the LAr config flags correctly. In MC23, LAr flags are set by a preInclude, e.g. `--preInclude "all:Campaigns.MC23a"`, calling [Campaigns/share/MC23a.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Tools/Campaigns/share/MC23a.py), in turn calling [LArConfiguration/share/LArConfigRun3Old.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/LArCalorimeter/LArConfiguration/share/LArConfigRun3Old.py). The jobproperties legacy flags are configured, but not propagated to [TriggerJobOpts/share/runHLT_standalone.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Trigger/TriggerCommon/TriggerJobOpts/share/runHLT_standalone.py) which rely on ConfigFlags. The mapping between legacy and config flags can be found in [thenaConfiguration/python/OldFlags2NewFlags.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Control/AthenaConfiguration/python/OldFlags2NewFlags.py#L109-127). After adding the mapping to runHLT_standalone, we get the following changes for MC23:
* flags.LAr.ROD.nSamples is now 4 instead of 5
* flags.LAr.ROD.UseHighestGainAutoCorr is now True instead of False
* flags.LAr.ROD.NumberOfCollisions is now 60 instead of 0

This bug is affecting the MC21a, MC23a and MC23c campaigns. It's impact is discussed in ATR-28590.

We don't expect the counts to change in the MC CI test, because the test doesn't specify a MC campaign in the preInclude...

The fix improves the agreement between CA and legacy configs (ATR-28470), the CA setup is not affected by the missing flag mapping.

Cheers,
Bertrand

Clean up of FTAG TrackClassificationTools

See merge request !68031

Thomas Strebler authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Clean up of FTAG TrackClassificationTools

Add functionality for DetectorType to ITk Strips

See merge request !68007

Nicholas Styles authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add functionality for DetectorType to ITk Strips

RootUtils+TrigNavStructure+LArCabling: Fix compilation with gcc14.

See merge request !68020

HI: set default test geometry tags

See merge request !68028