Former-commit-id: 0ea67d5acf4d52932c9c2bc9e49119290749b014

Former-commit-id: 0faa6cc6

Former-commit-id: 823f6fae

Manual cherry-pick of MR !3155


Former-commit-id: 13d2b993

This hopefully also unstucks the CI tests of the MR.


Former-commit-id: a62fef85

Former-commit-id: 2a0f02b825a01730e2076709becedf20005a3d29

Introduce another level here to be able to use the same configuration file in all branches.

Former-commit-id: b2ecd41d

Former-commit-id: 8d9d05da

- adding MR sweep script
- various updates to watch list
- improved domain definitions
- store unit test output in logfile for upload to NICOS
- smaller cosmetic changes to atlasbot comments


Former-commit-id: a4af44fa80bc51fb5a7d93144598498e462fed7c

Former-commit-id: a5f6cc2b

The python scripts used by the CI system have evolved a bit. While
the current version of the CI scripts in 21.0 are still functional
they exhibit a different subtly different behavior (most importantly
the assignment of review labels). To simplify the life of the MR
review shifters and to streamline the CI setup, this MR brings in
the changes to the CI scripts from the master branch.


Former-commit-id: 29ff962eed9d7851fce8e404329c19503d89a63a

Updates to the Jenkins CI infrastructure rely on some changes in the
CI scripts. This MR ports those changes from the master branch.


Former-commit-id: b702d079

Former-commit-id: 8cde96e1

In the case of short-circuited MRs (skipping the review process),
a MR can be closed before the CI job for assigning the Gitlab labels
is run. In this case, domain labels should still be assigned to
facilitate future searches for MRs by domain. Review labels are still
added in case a post-facto review is desired.


Former-commit-id: 7b12fb51

Due to the problem of creating duplicate CI jobs when a MR is updated
while the initial CI job is still running, a mechanism has been put
in place to cancel the second (duplicate) job. This leads to a failed
Jenkins CI job. Publishing the build status using the functionality
of the jenkins-gitlab plugin would cause major confusion since the
developer would quickly get a 'failed build' comment from the aborted
job and later the actual build result from the initial CI job (which
can take up to 5h to complete). Therefore, this functionality is not
used but a comment with the build status (and links to the logfiles)
is added manually to the Gitlab MR discussion.


Former-commit-id: babe005c

Former-commit-id: a5a37ae4

Former-commit-id: 8408e2e8

Former-commit-id: e2bc07f2

Former-commit-id: 5f693b27cda4c5c1492d264d4e2d2abcff381bee

Former-commit-id: b155bf98

Since the set of affected packages is used in various places of this code,
it should not be modified in any of those functions.


Former-commit-id: 012ea937

For repository-wide changes, many packages are affected. If the list
of affected packages becomes very long, the automatic comment from
the atlasbot does not really help, but only makes following the
discussion on the Gitlab web interface more difficult. Therefore,
the list of affected packages is only printed for at most 20 packages.

Closes ATLINFR-1488


Former-commit-id: c5080e62

If the list of affected packages grows large, having them sorted
alphabetically helps finding individual packages.


Former-commit-id: c844da50

Since at the moment it is not possible to filter MRs in Gitlab based
on their target branch, we add a label specifying the target branch
manually. In this way, review shifters and release coordinators can
easily filter MRs by their target release.


Former-commit-id: f6c9b071

cherry-picked from 507b29295bf5dd0d66 [formerly 66fe598885987cc7c3]


Former-commit-id: c8f7a2c5

The way how we detect include-directories of Athena packages may
seem a bit complicated. The logic is now described better.


Former-commit-id: 19f9ece5

Former-commit-id: 71905d54

More descriptive variable names are used in list comprehensions.
Also, the way the log level is set (introduced in 3d42f186) does
not work as expected and has been fixed.


Former-commit-id: fdc060a4a528cb7378b7281bc580b8e04d2a6cd6

Former-commit-id: 36e47433

Former-commit-id: 553d83a4

The 'eval()' function is actually not needed and poses a security
risk. The logging module understands string arguments to the log
level as well.


Former-commit-id: 7f58ad58a9ca4bdbe580f35bb4921f52fc6bf812

Rejected was quite strong. In case changes are really rejected, it
is sufficient to comment and close the MR. There is no need to label
those MR as rejected. In case the MR needs some more work from the
developer the label 'review-postponed' should be added.


Former-commit-id: 69277c8b

All unit tests are labelled in ctest with the name of the package.
For very short package names (e.g. CI) this could lead to false-
positive matches (e.g. LUCID...). This is improved by requiring that
the package should match the beginning of the unit test label.


Former-commit-id: af32abe0

Similar to the rest of the CI scripts, we can make use of the
python-gitlab module which is a neat wrapper around the Gitlab API.
Previously there was a bug when fetching the changes introduced by
a merge request. This is fixed in python-gitlab v0.17. Therefore,
the manual workaround using HTTP requests directly is not needed
any longer.


Former-commit-id: 31762bcf

This ports the tested CI setup from the aogt8 git repository.


Former-commit-id: 1be771e8