Shaun Roe authored 9 months ago and Frank Winklmeier committed 9 months ago

main-coverity-MCTruth

John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Introduce a common naming scheme for methods and variables related to GenParticles representing particles after all interactions so far

Rename variables and methods related to GenParticles representing the particle being simulated after all interactions so far

John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Introduce a common naming scheme for methods and variables related to primary GenParticles

John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Drop redundant PrimaryParticleInformation::SetParticle() method

John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Clean-up of AtlasG4EventUserInfo

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

HepMcParticleLink constructor syntax clean-up.

Avoid using 0 in combination with HepMcParticleLink::IS_EVENTNUM in constructor calls as this is not properly supported.
It is more correct to directly use 0 with HepMcParticleLink::IS_POSITION to indicate that the link is to the first
GenEvent in the McEventCollection.

John Derek Chapman authored 11 months ago and Edward Moyse committed 11 months ago

Add status to transient TrackRecord class and add, but not use a new persistent class

John Derek Chapman authored 1 year ago and Frank Winklmeier committed 1 year ago

Migrate Sensitive Detectors to use ID rather than barcode

John Derek Chapman authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Update HepMcParticleLink interface and clients without changing behaviour

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Remove barcodes from the print statements and comments

John Derek Chapman authored 1 year ago and Edward Moyse committed 1 year ago

Compilation fixes for the main--HepMC2 nightly

John Derek Chapman authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Update TrackBarcodeInfo constructor to take uniqueID as well as barcode + replace some calls to GetParticleBarcode with GetParticleUniqueID

Update classes in MCTruth package to handle Status and UniqueID (part of Barcode migration) (ATLASSIM-6978)

Andrii Verbytskyi authored 2 years ago and Frank Winklmeier committed 2 years ago

cache the barcodes in Simulation/G4Sim/MCTruth/MCTruth/

Andrii Verbytskyi authored 2 years ago and Edward Moyse committed 2 years ago

Avoid copying of shared pointers

Passing pointer member to a non-const pointer from a const method.

This is similar to !58354 and removes unnecessary `const` qualifiers on
`GenParticle` and `ISFParticle` to avoid `const_cast` downstream for
the following classes:
- `PrimaryParticleInformation`
- `TrackBarcodeInfo`
- `TrackInformation`
- `VTrackInformation`

Enable thread-safety checking.
Clean up use of singleton.

The `EventInformation` class inherits from the `G4VUserEventInformation` class.
It is used to pass around additional information about the truth particle
currently being processed.
However, the name is very similar to the `(xAOD::)EventInfo` object used
elsewhere in Athena. In order to avoid this clash this commit renames the
`EventInformation` class to `AtlasG4EventUserInfo`.

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

This reverts commit 9156e32ac88ebae9bf90ce0c19a40933a6fb097e [formerly f73d17d3f46239034e6ab596ed09b9aa922f4ad5], reversing
changes made to 27d106d1c78657e78ee8e51365e28572176cf185 [formerly 8f2f51887120a7b1cc2c7aff8c3101d0e69d4a2d].


Former-commit-id: 9d67f5b8a4078841f852715040f5a05bd7efc41b

Manual sweep of from '21.3' to '21.0': Sim helpers tidying

See merge request !6391


Former-commit-id: f9d53675

Private class members should start with m_.



Former-commit-id: 6d37fd66

MCTruth/TrackHelper.h, src/TrackHelper.cxx - add GetParticleLink method to build a HepMcParticleLink corresponding to the current G4Track. Includes commented out code for post-HepMcParticleLink migration (ATLASSIM-2430). CMakeLists.txt, cmt/requirements - add use statements for GeneratorObjects and ISF_Event. Tagging MCTruth-00-05-00 (MCTruth-00-05-00)

2016-07-14  John Chapman  <John.Chapman@cern.ch>

	* MCTruth/TrackHelper.h, src/TrackHelper.cxx - add GetParticleLink
	method to build a HepMcParticleLink corresponding to the current
	G4Track. Includes commented out code for post-HepMcParticleLink
	migration (ATLASSIM-2430).
	* CMakeLists.txt, cmt/requirements - add use statements for
	GeneratorObjects and ISF_Event.
	* tagging MCTruth-00-05-00


Former-commit-id: b81f338062a3b8ca44bf6ad29aea1c4fe2e53441

Merge changes from MCTruth-00-02-00->MCTruth-00-02-00-03 into trunk. ATLASSIM-2701 : Add pointer to primary (generator) MC truth particle to VTrackInformation. Critical for fix of incorret calibration hits assignment. ATLASSIM-2456 + Introduce more appropriate naming for pointer to base ISFParticle in various TrackInformation classes. (MCTruth-00-04-00)

	* Merge changes from MCTruth-00-02-00->MCTruth-00-02-00-03 into trunk.
	ATLASSIM-2701 :
		* Add pointer to primary (generator) MC truth particle to
		VTrackInformation. Critical for fix of incorret calibration hits
		assignment. ATLASSIM-2456
		* Introduce more appropriate naming for pointer to base ISFParticle
		in various TrackInformation classes.
	* tagging MCTruth-00-04-00

2015-09-15  John Chapman  <John.Chapman@cern.ch>
	* Removed MCTruth/CosmicTRSD.h, src/CosmicTRSD.cxx,
	MCTruth/TrackRecorderSD.h, src/TrackRecorderSD.cxx - Merged into
	TrackWriteFastSim/TrackWriteFastSD. ATLASSIM-2144. Requires
	TrackWriteFastSim-00-03-00 or later.
	* Removed MCTruth/TruthStrategy.h, src/TruthStrategy.cxx,
	MCTruth/TruthStrategyManager.h, src/TruthStrategyManager.cxx,
	MCTruth/MCTruthSteppingAction.h, src/MCTruthSteppingAction.cxx,
	MCTruth/AtlasTrajectory.h, src/AtlasTrajectory.cxx,
	src/components, python - moved to MCTruthBase. Requires
	MCTruthBase-00-01-01 onwards. ATLASSIM-2144
...
(Long ChangeLog diff - truncated)

MCTruth/AtlasTrajectory.h, src/AtlasTrajectory.cxx - use G4VERSION_NUMBER variable to restore compatibility with G4 versions older than 10.1. src/TruthStrategyManager.cxx - set the GenVertex ID for secondary vertices to the G4 process subtype + 1000. ATLASSIM-2055. Tagging: MCTruth-00-02-00 (MCTruth-00-02-00)

	* MCTruth/AtlasTrajectory.h, src/AtlasTrajectory.cxx - use
	G4VERSION_NUMBER variable to restore compatibility with G4
	versions older than 10.1.
	* src/TruthStrategyManager.cxx - set the GenVertex ID for
	secondary vertices to the G4 process subtype +
	1000. ATLASSIM-2055.
	* Tagging: MCTruth-00-02-00

2015-03-12  Zach Marshall <ZLMarshall@lbl.gov>
	* Fixing warning in DrawTrajectory; ATLASSIM-1879; for real this time
	* Tagging: MCTruth-00-01-18

	* Fixing warning in DrawTrajectory; ATLASSIM-1879
	* Tagging: MCTruth-00-01-17

	* Updating TrackRecordCollection to vector<T>
	* Tagging: MCTruth-00-01-16

2015-01-17  Elmar Ritsch <Elmar.Ritsch@cern.ch>
	* Fixing uninitialized member variable in one of the TrackInformation
	constructors (ATLASSIM-1738)
	* Tagging: MCTruth-00-01-15

2015-01-17  Elmar Ritsch <Elmar.Ritsch@cern.ch>
	* Fixing uninitialized member variable in TrackBarcodeInfo constructor
	(ATLASSIM-1738)
	* Tagging: MCTruth-00-01-14

2015-01-16  Elmar Ritsch <Elmar.Ritsch@cern.ch>
	* Adding boolean flag in VTrackInformation (+derived classes) for tracks
	that were returned to the ISF (ATLASSIM-1738)
	* Tagging: MCTruth-00-01-13

	* Adding a check for volume depth during init of truth strategies
	* Tagging: MCTruth-00-01-12