TrigInDetValidation: Changing the muon LRT chains used for Validation, as the ones previously used have been removed

TrigInDetAnalysisUser: Modifying the cut for pT histograms, so it can include the efficiencies of the LRT chains

TrigInDetValidation: Adding of the precision tracking LRT electron chains to the Validation
Modification of the truth matching option in the test for LRT electron chains on StauStau samples

Mark Sutton authored 3 years ago and Johannes Elmsheuser committed 3 years ago

Had selecting chains as e idperf chains were not implemented

Savanna Shaw authored 3 years ago and Edward Moyse committed 3 years ago

As pointed out in ATR-23252, it would be better to use the same RoIs for the fast and precision tracking and combined muon building steps. To do this, have added a link to the RoI in the L2 combined muon hypo alg, and switched the EF combined muon input maker to use the NamedRoITool instead of just fetching the RoI from the previous step (the EF SA muon rois from the previous step are similar but not quite identical to the combined muon RoIs).

Mark Sutton authored 3 years ago and Frank Winklmeier committed 3 years ago

Changes to run both iterative and adaptive vertex algorithms in the FS tracking from the jets,
including factorising out the TTVA such that we can run separate instances of the TTVA for each
algorithm.

This also changes the default vertex algorithm to be the adaptive, so that the counts will change

- in principle the purpose of this change is to allow the jets to still use the iterative algorithm,
so some further changes will be necessary in the code to switch to use this different vertex.

Mark Sutton authored 3 years ago and Walter Lampl committed 3 years ago

Add the relevat analysis chain to estimate the tau efficiency
- still some work to do on this, since the tau reconstruction runs in
an Roi, and so we need to reject vertex candidates with no offline
tracks in the tau Roi.

Julie Kirk authored 4 years ago and Edward Moyse committed 4 years ago

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfigMT_Ntuple.cxx
	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_Base.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/comparitor.json
	new file:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_FSLRT_RHadron.py

Mark Sutton authored 4 years ago and Frank Winklmeier committed 4 years ago

Previously we were monitoring selecting ivarmedium chains, as not muIso performance chain
was available.

We have a the ivarperf chain now, added by Savanna, which run the same as the ivarmedium
chain, but runs the final hypo in passthrough.

Eva Guilloton authored 4 years ago and Walter Lampl committed 4 years ago

Adding of a standard muon chain for comparison step

Mark Sutton authored 4 years ago and Walter Lampl committed 4 years ago

Typos and mistakes in the chain configuration prevented the analyses working correctly.

In addition, the release for the reference reconstruction is changed so that we can see
the collections in the AOD

We run two vertex analyses - one in the standard offline processing,
and another with a primary vertex selection. This second processing
would previously also re-run all the other ttbar based analyses.

In the ttbar jobs, these take some considreable time, and are not needed,
as they have already been run in the standard job.

This adds a preprocessor macros to skip the confguration of the non-vertex
analysis chain for the primary vertex analysis

Code to specifiy that the muonIso chains should run, then that they should
be post-processed and and plotted

The post processing chains are incorrect for the muon precision tracking so none
of the analyses this has been changed.

These changes are only used by the ID Trigger post processing for the nightly tests

Julie Kirk authored 4 years ago and Walter Lampl committed 4 years ago

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat

	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/share/comparitor.json

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_jpsiee_pu40.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_jpsiee_pu40_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0_pu.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0_pu_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_pu40.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_pu40_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_zee_pu40.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_zee_pu40_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_bphys.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_bphys_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0_pu.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0_pu_mt.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_zmumu_pu40.py

	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_zmumu_pu40_mt.py

Mark Sutton authored 4 years ago and Walter Lampl committed 4 years ago

Add a full scan test, add additional panels to the plotting, fix the incorrect selection of histograms

An extra validation test running the fullscan tests is added - running from a jet chain, rather than
a bjet chain (will need a jet performance test at some point)

In addition, it adds extra panels for the plotting showing the hit multiplicities and the raw distributions.

Finally, a fix to the configuration of the histogram selection in the FTF monitoring has been added.

Julie Kirk authored 4 years ago and Adam Edward Barton committed 4 years ago

1) add post-exec to all tests by default

2) Increase number of events in some tests

3) Remove a couple of no longer needed tests

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	deleted:    Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_bjet_olddata_pu40.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_larged0_pu.py
	deleted:    Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_long.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_singlee_7-80_pu40.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_el_zee_pu40.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_singlemu_larged0_pu.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_zmumu_pu40.py

Julie Kirk authored 4 years ago and Adam Edward Barton committed 4 years ago

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py
	new file:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_minbias.py

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_all_ttbar_pu40.py

	modified:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_all_ttbar_pu80_grid.py

Julie Kirk authored 4 years ago and Frank Winklmeier committed 4 years ago

	new file:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-chains-run3.dat
	new file:   Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAdata-run3.dat
	modified:   Trigger/TrigValidation/TrigInDetValidation/CMakeLists.txt
	modified:   Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
	renamed:    Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_RTT_tida22.py -> Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py
	new file:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_all_ttbar_pu80_grid.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_zmumu_pu40_build.py
	modified:   Trigger/TrigValidation/TrigInDetValidation/test/test_trigID_mu_zmumu_pu40_grid.py