Remove support for pre-MT thinning.

Library dependency fixes.

Library dependency fixes.

Change CaloBCIDAverage so that the vector of results is held
as a vec_aligned_vector.

Change CaloBCIDAvgAlg to use the CaloBCIDCoeffs / CaloBCIDLumi conditions
objects.  Should significantly speed up this calculation.

Library dependency fixes.

Library dependency fixes.

    
Add CaloBCIDCoeffsCondAlg and CaloBCIDLumiCondAlg, to allow speeding
up the offset calculation by doing much of the work in them rather than
on each event.

Updates for python 3 compatibility.
Enable flake8 checking and fix warnings.

Fix wraparound handling in the filling of lumiVec for the MC case.

That variable will be set on the project level in the future, the packages
should not bother setting it themselves.

Although clang now supports function multiversioning, it does not
support the target_clones attribute.  Change test on 
HAVE_FUNCTION_MULTIVERSIONING to HAVE_TARGET_CLONES.

Move new CaloBCID conditions code to a new package, CaloLumiConditions.  CaloConditions cannot depend on LumiBlockData as it is used by AthSimulation.

Need to make Tool ctors/dtor NOT_THREAD_SAFE because it contains
a DataHandle member.

Pending updates to the checker start catching this.

The cell-by-cell luminosity-dependent offset correction for adjacent bunches
was implemented as an algorithm (CaloBCIDAvgAlg), but this took too long
to be usable in the trigger.  We can, however, speed it up dramatically
by doing much of the work in advance and vectorizing the remainder.
The processed data depends on the cell pulse shapes and OFCs as well
as the per-bunch luminosity.  The first two of these are saved in
CaloBCIDCoeffs and the third (because it has a different lifetime)
in CaloBCIDLumi.

Fix spacing in error message.

Frank Winklmeier authored 5 years ago and Edward Moyse committed 5 years ago

Move the setup of the AllCaloFull container to the `setUp()` function to
avoid failure in recording it when called multiple times.

Mark ICaloTowerBuilderToolBase::initialize as not thread-safe,
to avoid warnings in the implementation.

Remove mutable from signal-state related members.
Add kinematics getters that request a specific signal state.

Remove const_casts related to m_dataLink.  Add another member
giving a non-const pointer to the store where appropriate.

Remove NOT_THREAD_SAFE annotation from CaloCluster.

ToolWithConstantsMixin::declareConstant was returning a StatusCode.
However, this is used in constructors, so in practice, the return
value was never being checked.  Pending changes to Gaudi will start
giving warnings about this.

There's no point in returning a StatusCode if it can't reasonably be checked,
so just change declareConstant (and add_constant) to be void.

Change the ISignalState::setSignalState and resetSignalState methods
to be (properly!) non-const.  SignalStateHelper now takes a non-const
pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
that takes a const pointer and does a const_cast on it; this is marked
as not thread-safe.

Remove now-unused SignalStateCollHelper.

Corresponding changes downstream.

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Adjust CaloBCIDAverage so that it holds its information in a flat vector,
rather than in a map.  Add methods to retrieve data by HWIdentifier
and index, in addition to offline Identifier.

    
Update to work with python 3.
    
Also add flake8 checking and fix warnings.

    
Update to work with python 3.
    
Also add flake8 checking and fix warnings.

    
Update to work with python 3.
    
Also add flake8 checking and fix warnings.

Don't use setSignalState in T->P conversion.  Instead, just copy the base
P4EEtaPhiM object.

Working on some constness/thread-safety cleanups.

Clean up signal state includes.

New TileCalCellMonAlg algorithm has been added to monitor TileCal Cell for run 3.
Functionality has just been copied from TileCalCellMonTool.

Configuration of TileCal Cell monitoring algorithm has been added for run 3.
Configuration of general Calo monitoring has been added for run 3.

TileCal Cell monitoring for Run 3 has been included
in general Calo monitoring configuration for run 3.

General Calo monitoring has been added to general ATLAS monitoring.

Test of TileCal Cell monitoring algorithm for run 3 has been added.

Update to work with python 3.  Also add flake8 checking and fix warnings.

Add interface libraries to export public headers for the following
packages:

CaloInterface
egammaInterfaces
xAODEgammaCnv
HIGlobal
TrigTools
TrigInDetToolInterfaces
TrigTrackJetFinderTool
TrigMuonBackExtrapolator
TrigMuonRoITools

Addresses ATLASRECTS-5295