Calorimeter/CaloMonitoring/CMakeLists.txt

@@ -33,7 +33,8 @@ atlas_depends_on_subdirs(
    Event/xAOD/xAODEventInfo
    LArCalorimeter/LArRecEvent
    Reconstruction/Jet/JetEvent
-   Reconstruction/RecBackground/RecBackgroundEvent )
+   Reconstruction/RecBackground/RecBackgroundEvent
+   Trigger/TriggerAnalysis/TrigAnalysisInterfaces )
 
 # External dependencies:
 find_package( ROOT COMPONENTS Core Hist MathCore Gpad )

Control/AthAllocators/AthAllocators/ArenaBlockAllocatorBase.h

 // This file's extension implies that it's C, but it's really -*- C++ -*-.
 
 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaBlockAllocatorBase.h 470529 2011-11-24 23:54:22Z ssnyder $
@@ -49,7 +49,7 @@ public:
   /**
    * @brief Destructor.
    */
-  ~ArenaBlockAllocatorBase();
+  virtual ~ArenaBlockAllocatorBase();
 
 
   /// Don't allow copy construction or assignment.
@@ -93,7 +93,7 @@ public:
    * It may not be possible to release the number of elements requested;
    * this should be implemented on a best-effort basis.
    */
-  virtual void reserve (size_t size);
+  virtual void reserve (size_t size) override;
 
 
   /**
@@ -104,19 +104,19 @@ public:
    * @c destructor should be called on them if it was provided
    * (preceded by @c clear if provided and @c mustClear was set).
    */
-  virtual void erase();
+  virtual void erase() override;
 
 
   /**
    * @brief Return the statistics block for this allocator.
    */
-  virtual Stats stats() const;
+  virtual Stats stats() const override;
 
 
   /**
    * @brief Return the name of this allocator.
    */
-  virtual const std::string& name() const;
+  virtual const std::string& name() const override;
 
 
   /**

Control/AthAllocators/AthAllocators/ArenaHeapAllocator.h

 // This file's extension implies that it's C, but it's really -*- C++ -*-.
 
 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaHeapAllocator.h 470529 2011-11-24 23:54:22Z ssnyder $
@@ -119,7 +119,7 @@ public:
   /**
    * @brief Destructor.  This will free all the Allocator's storage.
    */
-  ~ArenaHeapAllocator();
+  virtual ~ArenaHeapAllocator();
 
 
   /// Don't allow copy construction or assignment.
@@ -171,7 +171,7 @@ public:
    * The elements may continue to be cached internally, without
    * returning to the system.
    */
-  virtual void reset();
+  virtual void reset() override;
 
 
   /**
@@ -182,7 +182,8 @@ public:
    * @c destructor should be called on them if it was provided
    * (preceded by @c clear if provided and @c mustClear was set).
    */
-  virtual void erase();
+  // cppcheck-suppress virtualCallInConstructor ; false positive
+  virtual void erase() override final;
 
 
   // These are just placeholders --- the iterators are not implemented.

Control/AthAllocators/AthAllocators/ArenaHeapSTLAllocator.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaHeapSTLAllocator.icc,v 1.2 2008-08-26 02:12:26 ssnyder Exp $
@@ -68,6 +68,7 @@ ArenaAllocatorBase::Params ArenaHeapSTLAllocator_initParams<T>::params() const
  *               allocator name.
  */
 template <class T, class VETO>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaHeapSTLAllocator<T, VETO>::ArenaHeapSTLAllocator
  (size_t nblock /*= 1000*/, const std::string& name /*= ""*/)
    : m_pool (ArenaHeapSTLAllocator_initParams<T> (nblock, name))
@@ -81,6 +82,7 @@ ArenaHeapSTLAllocator<T, VETO>::ArenaHeapSTLAllocator
  * The @c name and @c nblock parameters are copied, but the data are not.
  */
 template <class T, class VETO>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaHeapSTLAllocator<T, VETO>::ArenaHeapSTLAllocator
   (const ArenaHeapSTLAllocator& a)
     : m_pool (ArenaHeapSTLAllocator_initParams<T> (a.nblock(), a.name()))
@@ -95,6 +97,7 @@ ArenaHeapSTLAllocator<T, VETO>::ArenaHeapSTLAllocator
  */
 template <class T, class VETO>
 template <class U, class V>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaHeapSTLAllocator<T, VETO>::ArenaHeapSTLAllocator
   (const ArenaHeapSTLAllocator<U, V>& a)
     : m_pool (ArenaHeapSTLAllocator_initParams<T> (a.nblock(), a.name()))
@@ -399,6 +402,7 @@ const ArenaAllocatorBase* ArenaHeapSTLAllocator<T, VETO>::poolptr() const
  *               allocator name.
  */
 template <class T>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaHeapSTLAllocator<T, T>::ArenaHeapSTLAllocator
  (size_t nblock /*= 1000*/, const std::string& name /*= ""*/)
     : m_nblock (nblock),
@@ -415,6 +419,7 @@ ArenaHeapSTLAllocator<T, T>::ArenaHeapSTLAllocator
  */
 template <class T>
 template <class U, class V>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaHeapSTLAllocator<T, T>::ArenaHeapSTLAllocator
   (const ArenaHeapSTLAllocator<U, V>& a)
     : m_nblock (a.nblock()),

Control/AthAllocators/AthAllocators/ArenaPoolAllocator.h

 // This file's extension implies that it's C, but it's really -*- C++ -*-.
 
 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaPoolAllocator.h 470529 2011-11-24 23:54:22Z ssnyder $
@@ -152,7 +152,7 @@ public:
   /**
    * @brief Destructor.  This will free all the Allocator's storage.
    */
-  ~ArenaPoolAllocator();
+  virtual ~ArenaPoolAllocator();
 
 
   /// Don't allow copy construction or assignment.
@@ -194,7 +194,7 @@ public:
    * The elements may continue to be cached internally, without
    * returning to the system.
    */
-  virtual void reset();
+  virtual void reset() override;
 
 
   /**
@@ -205,7 +205,8 @@ public:
    * @c destructor should be called on them if it was provided
    * (preceded by @c clear if provided and @c mustClear was set).
    */
-  virtual void erase();
+  // cppcheck-suppress virtualCallInConstructor ; false positive
+  virtual void erase() override final;
 
 
   /**

Control/AthAllocators/AthAllocators/ArenaPoolSTLAllocator.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaPoolSTLAllocator.icc,v 1.2 2008-08-26 02:12:26 ssnyder Exp $
@@ -425,6 +425,7 @@ ArenaPoolSTLAllocator<T*, VETO>::ArenaPoolSTLAllocator
  *               allocator name.
  */
 template <class T>
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaPoolSTLAllocator<T, T>::ArenaPoolSTLAllocator
  (size_t nblock /*= 1000*/, const std::string& name /*= ""*/)
     : m_nblock (nblock),

Control/AthAllocators/src/ArenaAllocatorBase.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaAllocatorBase.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -22,6 +22,7 @@ namespace SG {
 /**
  * @brief Constructor for a single statistic.
  */
+// cppcheck-suppress uninitMemberVar ; false positive
 ArenaAllocatorBase::Stats::Stat::Stat()
   : inuse (0),
     free (0),

Control/AthAllocators/src/ArenaBlockAllocatorBase.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaBlockAllocatorBase.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -26,7 +26,8 @@ namespace SG {
 ArenaBlockAllocatorBase::ArenaBlockAllocatorBase (const Params& params)
   : m_params (params),
     m_blocks (nullptr),
-    m_freeblocks (nullptr)
+    m_freeblocks (nullptr),
+    m_stats()
 {
 }
 

Control/AthAllocators/src/ArenaHeapAllocator.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaHeapAllocator.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -186,7 +186,7 @@ void ArenaHeapAllocator::slowClear()
   std::vector<ArenaBlock*>::iterator bi = blocks.begin();
   std::vector<ArenaBlock*>::iterator bi_end = blocks.end();
   func_t* clear = m_params.clear;
-  for (; bi != bi_end; bi++) {
+  for (; bi != bi_end; ++bi) {
     ArenaBlock& bl = **bi;
     size_t sz = bl.size();
     size_t elt_size = bl.eltSize();

Control/AthAllocators/test/ArenaBase_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaBase_test.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -51,6 +51,7 @@ Alloc::Alloc (int x)
 
   std::ostringstream os;
   os << "alloc" << x;
+  // cppcheck-suppress useInitializationList
   m_name = os.str();
 }
 

Control/AthAllocators/test/ArenaHandleBaseAllocT_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaHandleBaseAllocT_test.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -20,7 +20,7 @@ class TestAlloc
   : public SG::ArenaAllocatorBase
 {
 public:
-  TestAlloc (Params  params) : m_params (std::move(params)) {}
+  TestAlloc (Params  params) : m_stats(), m_params (std::move(params)) {}
   virtual void reset() override {}
   virtual void erase() override {}
   virtual void reserve(size_t) override {}

Control/AthAllocators/test/ArenaHandleBaseT_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaHandleBaseT_test.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -53,7 +53,7 @@ public:
     iterator (std::vector<Payload>::iterator it)
       : m_it (std::move(it)) {}
     reference operator*() const { return *m_it; }
-    iterator& operator++() { m_it++; return *this; }
+    iterator& operator++() { ++m_it; return *this; }
     bool operator== (const iterator& other) const
     { return m_it == other.m_it; }
 
@@ -72,7 +72,7 @@ public:
     const_iterator (TestAlloc::iterator it)
       : m_it (&*it) {}
     reference operator*() const { return *m_it; }
-    const_iterator& operator++() { m_it++; return *this; }
+    const_iterator& operator++() { ++m_it; return *this; }
     bool operator== (const const_iterator& other) const
     { return m_it == other.m_it; }
     bool operator== (const TestAlloc::iterator& other) const
@@ -99,7 +99,8 @@ private:
 
 
 TestAlloc::TestAlloc (Params  params)
-  : m_params (std::move(params))
+  : m_stats(),
+    m_params (std::move(params))
 {
   for (int i = 0; i < 10; i++)
     m_vec.push_back (i);

Control/AthAllocators/test/ArenaSharedHeapSTLAllocator_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: ArenaSharedHeapSTLAllocator_test.cxx 470825 2011-11-25 23:20:57Z ssnyder $
@@ -41,6 +41,7 @@ struct Payload
   static std::vector<int> v ATLAS_THREAD_SAFE;
 };
 
+// cppcheck-suppress uninitMemberVar ; false positive
 Payload::Payload(int the_y)
 {
   x = n++;

Control/AthAllocators/test/Arena_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id: Arena_test.cxx 470529 2011-11-24 23:54:22Z ssnyder $
@@ -48,6 +48,7 @@ Alloc::Alloc (int x)
 
   std::ostringstream os;
   os << "alloc" << x;
+  // cppcheck-suppress useInitializationList
   m_name = os.str();
 }
 

Control/AthAllocators/test/DataPool_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 #undef NDEBUG
@@ -21,17 +21,12 @@ class Fluff
 {
 	public:
 		virtual ~Fluff() { }
-		Fluff() : m_int(1), m_float(-379.456f),
+		Fluff() : m_int(1),
 			m_string("this is the Fluff struct")
 		{
 		}
 
-		Fluff(const Fluff& f)
-		{
-			m_int = f.m_int;
-			m_float = f.m_float;
-			m_string = f.m_string;
-		}
+		Fluff(const Fluff& f) = default;
                 Fluff& operator= (const Fluff&) = default;
 
 		void setPar(int j) { m_int = j; }
@@ -40,7 +35,6 @@ class Fluff
 	private:
 
 		int m_int;
-		float m_float;
 		string m_string;
 
 };
@@ -127,7 +121,7 @@ int main ATLAS_NOT_THREAD_SAFE ()
 	int k = 10;
 	DataPool<Fluff>::const_iterator iter2 = df->begin();
 	DataPool<Fluff>::const_iterator iend2 = df->end();
-	for (; iter2 != iend2; iter2++)
+	for (; iter2 != iend2; ++iter2)
 	{
 		assert(nullptr != (*iter2));
                 // Note: we iterate backwards...

Control/AthLinks/test/GenericElementLinkBase_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id$
@@ -45,7 +45,7 @@ CLASS_DEF (StrSet, strsetclid, 1)
 struct Bar
   : public std::string
 {
-  Bar (std::string the_s = "") : std::string(the_s), s (the_s+"asd") {}
+  Bar (const std::string& the_s = "") : std::string(the_s), s (the_s+"asd") {}
   std::string s;
 };
 

Control/AthLinks/test/IdentContIndexingPolicy_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id$
@@ -57,7 +57,7 @@ public:
   const_iterator indexFind(int hash) const
   { return const_iterator (m_map.find (hash)); }
 
-  void set (unsigned hash, unsigned idx, std::string val)
+  void set (unsigned hash, unsigned idx, const std::string& val)
   {
     IDENTIFIABLE& i = m_map[hash];
     i.m_hash = hash;

Control/AthLinksSA/AthLinks/ElementLink.h

@@ -154,6 +154,11 @@ public:
    /// Get the key that we reference, as a hash
    sgkey_t key() const { return persKey(); }
 
+   /// Comparison operator
+   bool operator==( const ElementLink& rhs ) const;
+   /// Comparison operator
+   bool operator!=( const ElementLink& rhs ) const;
+
    /// Get a reference to the object in question
    ElementConstReference operator*() const;
 

Control/AthLinksSA/AthLinks/ElementLink.icc

@@ -381,6 +381,18 @@ ElementLink< STORABLE >::dataID() const {
    return m_event->getName( persKey() );
 }
 
+template< typename STORABLE >
+bool ElementLink< STORABLE >::operator==( const ElementLink& rhs ) const {
+
+   return ( ( key() == rhs.key() ) && ( index() == rhs.index() ) );
+}
+
+template< typename STORABLE >
+bool ElementLink< STORABLE >::operator!=( const ElementLink& rhs ) const {
+
+   return ( ! ( *this == rhs ) );
+}
+
 template< typename STORABLE >
 typename ElementLink< STORABLE >::ElementConstReference
 ElementLink< STORABLE >::operator*() const {

Control/AthLinksSA/AthLinks/ElementLinkVector.h

@@ -79,6 +79,11 @@ public:
    /// Assignment operator
    ElemLinkVec& operator=( const ElemLinkVec& rhs );
 
+   /// Comparison operator
+   bool operator==( const ElementLinkVector& rhs ) const;
+   /// Comparison operator
+   bool operator!=( const ElementLinkVector& rhs ) const;   
+
    /// @name Vector iterator functions
    /// @{