new HLTCalo configuration

Just to make an example running HLTCalo algorithms in parallel, running in views the L2Calo and topo Cluster as part of the main sequence.

added 1 commit

• 10264449 - Fix by Tomasz to help with turning on the HLTCalo views example

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @damazio as watcher

added Trigger master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20030-2018-12-20-00-37
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31744] (for remote access see the FAQ for MR reviewers)

@tbold, I tried to understand the error, but it is not very clear to me. Seems unrelated..

Actually, it is. Even worse. We got to the limit of the validation that we can do with reference files. In this particular case, the output was mangled because you run two threads. I see two longer-term options which I'll discuss in upgrade group. In short term,​ I suggest you switch the test to a single thread.

Hello Tomasz.. I was trying to check on my phone and could not see that far.. Let me re-check.. But if that is the case, at least the solution is easy..

added 1 commit

• 9b10cfe5 - coming back to single thread

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @damazio as watcher

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20030-2018-12-20-13-29
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31782] (for remote access see the FAQ for MR reviewers)

ok.. That should be good then.. Can Mr. Shifter go ahead?! Denis

Just committed...

added 1 commit

• 463182d1 - some corrections proposed by Frank. Remove of print out and concurrent events in 1 thread case

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @damazio as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests	N/A	N/A

Full details available at NICOS MR-20030-2018-12-21-20-45
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31818] (for remote access see the FAQ for MR reviewers)

Why failure??

Integration tests did not run. It is a technical problem. I am restarting.

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @damazio as watcher

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20030-2018-12-22-02-24
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31822] (for remote access see the FAQ for MR reviewers)

Looks fine from MR shifter point of view.

Maybe one comment, for the next time, @damazio if you are introducing new file, year in copyright should correspond to the current year.

Pavol [as L2 MR shifter]

resolved all discussions

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit f93c933e

added sweep:ignore label