code cleaning and mapping tool update

The following changes are made:

1. temporary trigger objects are handled by std::map

2. temporary trigger objects are now smart pointers to prevent potential memory leak

3. mappling format is switched from std::map to std::vec

This merge request affects 2 packages:

• Calorimeter/CaloTriggerTool
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @pavol as watcher

added 21.3 Calorimeter JetEtmiss Trigger review-pending-level-1 labels

Hi @bcarlson @amyers @ckaldero

this commit has the changes into JetAlg and METAlg.

Let me know if you have any comment.

(I can switch the title to WIP)

Chiao-Ying

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20038-2018-12-19-21-01
Athena: number of compilation errors 0, warnings 170
For experts only: Jenkins output [CI-MERGE-REQUEST 31736] (for remote access see the FAQ for MR reviewers)

@cylin, could you please add ATLAS Robot as developer to your new fork (https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot)?

Thanks, Tadej (L1)

@tadej, ATLAS Robot has been added as developer to requested fork

• Jake (L1 Shifter)

resolved all discussions

Otherwise changes looks fine to me, so approving.

pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

This merge request affects 2 packages:

• Calorimeter/CaloTriggerTool
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @pavol as watcher

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20038-2018-12-24-13-49
Athena: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 31843] (for remote access see the FAQ for MR reviewers)

reapproving.....

Pavo [as l2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4951ed3d

mentioned in commit ckaldero/athena@a72bfe40

added sweep:done label

mentioned in commit c6314eae

Sweep summary
successful:

• 21.9

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/642/console for details)

mentioned in merge request !20211 (merged)

mentioned in commit 6ad426db