Muon BS to RDO caching for multi-threading - CSC technology
This MR (WIP for now) continues the work initiated by @markowen, and was closed during the private->public repository migration (see athenaprivate1!16700). As this was a branch off of Mark's fork, it was not straight-forward to patch so I have had to do a manual diff/merge procedure to bring into the new repository. The code is currently compiling correctly but will need to be tested as it is further developed.
Merge request reports
Activity
Hi @iconnell , please, add the ATLAS robot as it is described here:
https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot
L1 shifter
added 1 commit
- bf20932e - Some bug fixes to the CSC ROD decoder which was not included correctly when…
added 355 commits
-
bf20932e...ddcbbf85 - 354 commits from branch
atlas:master - 5fd4773e - Fixing conflict with new warning variable added to MuonCacheCreator in master
-
bf20932e...ddcbbf85 - 354 commits from branch
added MuonSpectrometer master review-pending-level-1 labels
Athena AthSimulation externals 
cmake make 
required tests optional tests 
Full details available at NICOS MR-20174-2019-01-10-20-05
For experts only: Jenkins output [CI-MERGE-REQUEST 32112] (for remote access see the FAQ for MR reviewers)added 1 commit
- 2a1c0bbe - Fixing error in failure to remove conflict marker
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-14-21-38
For experts only: Jenkins output [CI-MERGE-REQUEST 32211] (for remote access see the FAQ for MR reviewers) removed review-pending-level-1 label
added review-pending-level-1 label
removed review-pending-level-1 label
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-15-21-25
For experts only: Jenkins output [CI-MERGE-REQUEST 32262] (for remote access see the FAQ for MR reviewers) The CI failed here because of some issues with externals updates (and is hopefully fixed in !20376 (merged)). It had compiled locally with r14 so I will ask the CI to rerun and see if it builds now.
Ian
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-16-15-40
For experts only: Jenkins output [CI-MERGE-REQUEST 32307] (for remote access see the FAQ for MR reviewers) added 1 commit
- 2ecaaf7c - Fix missing StatusCode check when adding to container
I believe I have fixed the errors in testing, but I am interested to check if a reference file is update in master or not as I see a ctest difference wrt a reference file which I don't think has changed due to my code, but it might be that the ctest was not run in whatever MR had an effect
Ian
added 1 commit
- 36911c01 - Adding a test for the caching which won't conflict with existing one
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-18-19-31
For experts only: Jenkins output [CI-MERGE-REQUEST 32415] (for remote access see the FAQ for MR reviewers) -
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-18-22-29
For experts only: Jenkins output [CI-MERGE-REQUEST 32418] (for remote access see the FAQ for MR reviewers) added 1 commit
- 4b99aef2 - adding a new ctest and moving issues relating to the cache creator into the new…
I have elected to change the
MuonDataDecodectest to run two instances. One runs the old test which was always in place, which does not use theMuonCacheCreatorfor the bytestream, and the second test runs the same test but turns on the cache forMDTandCSCtechnologies. The former of which Mark had already implemented, and the latter I have implemented in this MR. Once this goes in, it should be more straight-forward to add the remaining technologies as only one test should change each time, and will help make sure that nothing was broken in the decoding.As such, I have had to regenerate the reference file for the existing test, and add a new one. It should be checked, but I have also run with different instances and do not see any problems showing up. In the new test, I also take the liberty of increasing the verbosity just to show that the
IdentifiableCachesare created and used. I will rerun the CI now to check the q-tests are okay.-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-21-20-18
For experts only: Jenkins output [CI-MERGE-REQUEST 32480] (for remote access see the FAQ for MR reviewers) added 369 commits
-
4b99aef2...ee0f89c0 - 368 commits from branch
atlas:master - aadecd31 - Merging with master 22Jan19 due to conflict
-
4b99aef2...ee0f89c0 - 368 commits from branch
added review-pending-level-1 label
removed review-pending-level-1 label
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20174-2019-01-22-20-56
For experts only: Jenkins output [CI-MERGE-REQUEST 32543] (for remote access see the FAQ for MR reviewers)