MuonMDT_Cabling: Avoid use of non-bound DataHandle.

Deprecating use of non-bound DataHandle, especially non-const.

This merge request affects 1 package:

• MuonSpectrometer/MuonCablings/MuonMDT_Cabling

Adding @rosati ,@wleight as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20182-2019-01-06-13-08
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31942] (for remote access see the FAQ for MR reviewers)

added review-user-action-required label

added 1 commit

• 02cc197f - Fix typo.

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonCablings/MuonMDT_Cabling

Adding @rosati ,@wleight as watchers

removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20182-2019-01-08-03-23
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31962] (for remote access see the FAQ for MR reviewers)

added review-approved label and removed review-pending-level-1 label

resolved all discussions

merged

mentioned in commit d46de52f

It looks like this broke MdtCalibSvc which now fails to compile. All pipelines started this afternoon for master are affected. See e.g.
https://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BS6G62AthenaOpt/NICOS_Log_MR-20091-2019-01-08-21-34/MuonSpectrometer_MuonCalib_MdtCalib_MdtCalibSvc.html

Not sure why MdtCalibSvc wasn't recompiled in the pipeline for this MR... @ssnyder, would you be able to fix the MdtCalibSvc issue?

Thanks,
Rafal

mentioned in merge request !20091 (merged)

added sweep:ignore label

mentioned in merge request !20240 (merged)

Hi @rbielski and @ssnyder ,

It looks like we got unlucky: as there aren't any conflicts between the two, !20189 (merged) was merged in at the same time as this, but the changes here need to be added to the new code introduced by that MR. I'm not sure if there's any way to make the CI smart enough to catch that. At any rate, I will try to make the fix this afternoon, if Scott doesn't get to it first.

thanks,

will

I opened a JIRA ticket for information: ATLINFR-2861

Kira (L1)

Hi all,

!20251 (merged) should provide the fix.

thanks,

will

Thanks Will!