TileConditions, etc: Make ITileCondToolOfc::getOfcWeights const.

The caching mechanism in TileCondToolOfc is not actually used anywhere, and it spoils the constness of the accessor method. Remove the caching and make the getOfcWeights() method const, changing the interface to take the output object by reference instead of returning it as a pointer. Also remove getNSamples(); it's not used anywhere.

Update clients accordingly.

This merge request affects 6 packages:

• TileCalorimeter/TileCalib/TileCalibAlgs
• TileCalorimeter/TileConditions
• TileCalorimeter/TileExample/TileRecEx
• TileCalorimeter/TileRecUtils
• TileCalorimeter/TileSvc/TileByteStream
• TileCalorimeter/TileTBRec

Adding @pavol ,@solodkov ,@harkusha as watchers

added JetEtmiss Tile master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20206-2019-01-08-06-13
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 31972] (for remote access see the FAQ for MR reviewers)

Looks OK. Approving.

Tadej (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 06407290

added sweep:ignore label