NSW MMSimHit (ATLASSIM-3755)

Create a new hit model(MMSimHit) for MM. But still keep GenericMuonSimHit.

This merge request affects 6 packages:

• MuonSpectrometer/MuonCnv/MuonSimEventAthenaPool
• MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonSimEvent
• Simulation/G4Atlas/G4AtlasApps
• Simulation/ISF/ISF_Example

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz as watchers

added 21.3 MuonSpectrometer Simulation review-pending-level-1 labels

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20259-2019-01-09-23-41
Athena: number of compilation errors 0, warnings 167
For experts only: Jenkins output [CI-MERGE-REQUEST 32066] (for remote access see the FAQ for MR reviewers)

The tests qTestsTier0_required-test and SimulationTier0Test-test failed. @jichen , I assume this happened due to your changes, and you need to fix it. If not, please, let us know.

L1 shifter

added review-user-action-required label

Hi @pberta,

My guess is that the unit tests failed due to !20228 (merged). The reference files have now been updated, so I think if we restart the pipeline things should look better.

Cheers,

John

Jenkins please retry a build

This merge request affects 6 packages:

• MuonSpectrometer/MuonCnv/MuonSimEventAthenaPool
• MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonSimEvent
• Simulation/G4Atlas/G4AtlasApps
• Simulation/ISF/ISF_Example

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz as watchers

removed review-user-action-required label

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20259-2019-01-10-18-38
Athena: number of compilation errors 0, warnings 167
For experts only: Jenkins output [CI-MERGE-REQUEST 32104] (for remote access see the FAQ for MR reviewers)

Hi @jichen, I have some comments:

• Please use std::make_unique and std::unique_ptr as std::auto_ptr is deprecated.
• Probably it's some memory optimisation, but why store float and then cast to double?
• CMT should really not be used anymore at this point (correct me if I'm wrong).

Also I think a L2 shifter and/or an expert will need to have a look.

Tadej (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 44 commits

• dca0234f...35177849 - 43 commits from branch atlas:21.3
• 6be7276e - Merge remote-tracking branch 'upstream/21.3' into NSWMMHit0701

Compare with previous version

This merge request affects 6 packages:

• MuonSpectrometer/MuonCnv/MuonSimEventAthenaPool
• MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonSimEvent
• Simulation/G4Atlas/G4AtlasApps
• Simulation/ISF/ISF_Example

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz as watchers