Support GSC for FTK b-jet chains

Following ATR-19193, some code changes in the configuration of FTK b-jet chains are needed in order to support GSC. This has been tested in 21.3 by adding some FTK+GSC b-jet chains in the Physics v7 menu and with the following command:

trigtest.pl --cleardir --test AthenaTrigRDO_MC_pp_v7_no_prescale_toxAOD_FTK --rundir AthenaTrigRDO_MC_pp_v7_no_prescale_toxAOD_FTK --conf TriggerTest.conf

Additional code changes have to be applied for addressing ATR-19262, but I'll open another MR for that since it is a different issue.

Tagging @jmontejo, @aranzazu and @baines

added Squash commits label

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TriggerCommon/TriggerMenu

Adding @sekula ,@cvarni as watchers

added 21.3 JetEtmiss Trigger TriggerMenu labels

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20263-2019-01-10-01-17
Athena: number of compilation errors 0, warnings 167
For experts only: Jenkins output [CI-MERGE-REQUEST 32071] (for remote access see the FAQ for MR reviewers)

unmarked as a Work In Progress

Hi @hartj, @rafal and @tamartin,

If I'm understanding the outcome, there are problems with the Tier0 test and some online BTagging variables. However, these should not be related to my changes. Is this expected/known a problem?

Cheers, Carlo

Looks like references are awaiting update after !20228 (merged)

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TriggerCommon/TriggerMenu

Adding @sekula ,@cvarni as watchers

added review-pending-level-1 label

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20263-2019-01-10-15-53
Athena: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST 32105] (for remote access see the FAQ for MR reviewers)

This one does look to be for you @cvarni :)

PyJobTransforms.trfValidation.scanLogFile 2019-01-10 15:20:39,957 INFO Error message "AlgErrorAuditor                                     ERROR Illegal Return Code: Algorithm EFGSCFexSplit_EFIF reported an ERROR, but returned a StatusCode "SUCCESS"" was ignored at line 109985 (structured match)
PyJobTransforms.trfExe.validate 2019-01-10 15:20:41,146 ERROR Fatal error in athena logfile (level ERROR)
PyJobTransforms.transform.execute 2019-01-10 15:20:41,147 CRITICAL Transform executor raised TransformLogfileErrorException: Fatal error in athena logfile: "Logfile error in log.RDOtoRDOTrigger: "EFGSCFexSplit_EFIF                                  ERROR INPUT - No xAOD::VertexContainer""
PyJobTransforms.transform.execute 2019-01-10 15:20:44,327 WARNING Transform now exiting early with exit code 68 (Fatal error in athena logfile: "Logfile error in log.RDOtoRDOTrigger: "EFGSCFexSplit_EFIF                                  ERROR INPUT - No xAOD::VertexContainer"")

Hi @tamartin. This is very strange. I see the following error message as if my changes are not being picked. May this be because all my changes are python and I've changed "EFGSCFexSplit_EFIF" into "EFGSCFexSplit_EFID"?

RDOtoRDOTrigger 15:19:45 EFGSCFexSplit_EFIF ERROR INPUT - No xAOD::VertexContainer RDOtoRDOTrigger 15:19:45 AlgErrorAuditor ERROR Illegal Return Code: Algorithm EFGSCFexSplit_EFIF reported an ERROR, but returned a StatusCode "SUCCESS" RDOtoRDOTrigger 15:19:45 Error policy described in https://twiki.cern.ch/twiki/bin/view/AtlasComputing/ReportingErrors RDOtoRDOTrigger 15:19:45 GSCBjetEtHypo_Btagging_45GeV WARNING Jet collection pointer is 0 RDOtoRDOTrigger 15:19:45 TrigSteer_HLT WARNING Sequence '' got error back while executing first algorithm 'GSCBjetEtHypo_Btagging_45GeV':ABORT_CHAIN UNKNOWN UNKNOWN

Hm, no the changes should be picked up. Trying to look further, but the python folder is missing from https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Trigger/TrigHypothesis/TrigBjetHypo/?v=21.3 ?!?

It is present here thought : https://gitlab.cern.ch/atlas/athena/tree/21.3/Trigger/TrigHypothesis/TrigBjetHypo

I wanted to check that there were no other instances of EFIF in the codebase, but a git grep confirmed

tamartin@pc-tbed-pub-22.cern.ch$ git grep EFIF upstream/21.3 -- Trigger/               
upstream/21.3:Trigger/TrigHypothesis/TrigBjetHypo/python/TrigGSCFexConfig.py:    return GSCFexSplit( instance=instance, name=instance+"GSCFexSplit_EFIF" )

So I am still confused...

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TriggerCommon/TriggerMenu

Adding @sekula ,@cvarni as watchers

c.f. !20280 (merged)