AthenaMonitoring: several improvements and cleanup (!20339) · Merge requests · atlas / athena · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption, please take a look at our documentation.

Frank Winklmeier requested to merge fwinkl/athena:monitored_cleanup into master Jan 14, 2019

HistogramDef: fix a parsing bug where the histogram definition string had to end with a trailing comma for 1D histograms without labels and options.
Remove the trailing comma produced by defineHistogram
Adapt the existing C++ unit tests and add a test for TProfile2D
Deprecate the use of "label1:label2" syntax in defineHistogram
Add a unit test for the defineHistogram method
Remove std imports

Make some trivial code changes to make it possible to compile some of the Monitored classes outside of athena:

Rely on explicit StatusCode->bool conversion instead of calling isFailure()
Add missing include files

Also change line endings from DOS to UNIX. Due to the latter make sure to use "Hide whitespace changes" when reviewing this MR.