Skip to content

AthenaMonitoring: several improvements and cleanup

Frank Winklmeier requested to merge fwinkl/athena:monitored_cleanup into master
  • HistogramDef: fix a parsing bug where the histogram definition string had to end with a trailing comma for 1D histograms without labels and options.
  • Remove the trailing comma produced by defineHistogram
  • Adapt the existing C++ unit tests and add a test for TProfile2D
  • Deprecate the use of "label1:label2" syntax in defineHistogram
  • Add a unit test for the defineHistogram method
  • Remove std imports

Make some trivial code changes to make it possible to compile some of the Monitored classes outside of athena:

  • Rely on explicit StatusCode->bool conversion instead of calling isFailure()
  • Add missing include files

Also change line endings from DOS to UNIX. Due to the latter make sure to use "Hide whitespace changes" when reviewing this MR.

cc @tbold

Merge request reports