Merge changes from Chuck's athenaprivate1 branch: new DQ framework

Updates to the AthenaMonitoring package for Run III. I produced an abstract AthMonitorAlgorithm class, which users can subclass and implement the fillHistograms() method. An example of this is done in AthenaMonitoring/src/ExamplateMonitorAlgorithm.cxx, which will be used for the DQ workshop starting 16 January.

The configuration of the algorithms and tools is done by the AthMonitorCfgHelper python code. Similarly, an example of this is given in AthenaMonitoring/python/ExampleMonitorAlgorithm.py

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/AthenaMonitoring

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

added 1 commit

• e1b9b054 - add missing module in AthenaMonitoring __init__

Compare with previous version

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/AthenaMonitoring

Adding @ssnyder as watcher

added 1 commit

• 8f8b06ba - make AthMonitorAlgorithm's lumi functions const

Compare with previous version

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/AthenaMonitoring

Adding @ssnyder as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20370-2019-01-15-17-08
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32255] (for remote access see the FAQ for MR reviewers)

Could we retry this build? the errors seem very unrelated to the MR.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20370-2019-01-15-18-29
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32261] (for remote access see the FAQ for MR reviewers)

So this failure is just the same one as above, but for the most recent commit with a few lines of change. (explained in the "Pipelines" tab)

i.e. It is still unrelated to this MR's changes.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20370-2019-01-15-19-11
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32260] (for remote access see the FAQ for MR reviewers)

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/AthenaMonitoring

Adding @ssnyder as watcher

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20370-2019-01-16-06-03
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32283] (for remote access see the FAQ for MR reviewers)

There is a small warning in the q221 test that a JSON file couldn't be found but I don't think that this is related to the MR and the test also passed. The Trigger MT test has errors for all MRs and is also independent.

From my point of view, the changes are fine. The only thing that should be updated are the copyright statements. The vary between 2017 and 2018 and should be 2019.

Regarding the large number of changes, passing on to L2. ExampleMonitorAlgorithm.cxx needs also be checked for memory management.

Kira (L1)

added review-pending-level-2 review-user-action-required labels and removed review-pending-level-1 label

added 1 commit

• 1ae7a610 - update copyright statements

Compare with previous version

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/AthenaMonitoring

Adding @ssnyder as watcher

added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

Dear Kira, (@kiabelin)

I've updated the copyright statements. The robot removed L2, so you may have to add it again. Thanks.

Chuck Burton

added review-pending-level-2 label and removed review-pending-level-1 label