Fix for post dec hackaton crash in ART tau trigger test

Need this to fix problem in calo only tau trigger test Tagging: @tbold & @fpastore

changed title from Fix for post dec hackaton crash in ART tau test to Fix for post dec hackaton crash in ART tau trigger test

changed the description

added 69 commits

• ec671960...cd3074af - 68 commits from branch master
• 68406d64 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into tauCaloFix

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigTauHypo

added Tau review-pending-level-1 labels

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigTauHypo

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20380-2019-01-16-00-39
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32276] (for remote access see the FAQ for MR reviewers)

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20380-2019-01-16-01-03
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32278] (for remote access see the FAQ for MR reviewers)

Hey @carquin,

The changes and the CI look fine in general. However, the Trigger_MT-test shows several errors and it would be great if you could check if they are expected or need to be fixed. The errors are:

M_trkInputMerger 0 0 DEBUG number of implicit ReadHandles for input decisions is 4, 4 are valid

M_trkInputMerger 0 0 DEBUG Produced 1 output decisions containers

M_trkInputMerger 0 0 ERROR Found 4 inputs and 1 outputs

and

ConditionStore WARNING retrieve(non-const): No valid proxy for object /TRT/Calib/errors2d of type CondContBase(CLID 34480459) Try to use a const retrieve

ReadCondHandle ERROR can't retrieve ( 'TRTCond::RtRelationMultChanContainer' , 'ConditionStore+/TRT/Calib/errors2d' ) via base class

TRTDriftCircleMaker_IDTrig ERROR std::exception caught: ReadCondHandle: ptr to CondCont is zero

TrigSteer_HLT WARNING Sequence got error back while executing algorithm: TRTDriftCircleMaker_IDTrig ABORT_CHAIN UNKNOWN STD_EXCEPTION

TrigSteer_HLT WARNING Chain HLT_3mu4_nomucomb_delayed aborting with error code ABORT_CHAIN UNKNOWN STD_EXCEPTION at step 4

TrigSteer_HLT WARNING Chain HLT_3mu4_nomucomb_mu4noL1 aborting with error code ABORT_CHAIN UNKNOWN STD_EXCEPTION at step 4

TrigSteer_HLT WARNING Chain HLT_3mu4_nomucomb_mu2noL1 aborting with error code ABORT_CHAIN UNKNOWN STD_EXCEPTION at step 4

TrigSteer_HLT WARNING Chain HLT_3mu4_nomucomb aborting with error code ABORT_CHAIN UNKNOWN STD_EXCEPTION at step 4

where the latter appears several times.

Thanks, Kira (L1)

Edit: Change the layout to make it easier to read

added review-user-action-required label and removed review-pending-level-1 label

Hi, They are unrelated as this test doe not run (yet) any taus code. Tagging @smh in case we can now do something to improve the state this test now.

Hi, the changes are fine, I think. We need to add the tau test to TUT, to test it. @carquin please can you add the tau test as a ctest in TrigUpgradeTest?

added 1 commit

• eaadd060 - Adding tauMenu test

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigUpgradeTest

added review-pending-level-1 label and removed review-user-action-required label

added 49 commits

• eaadd060...6dc6fe2d - 48 commits from branch master
• eeb8e41d - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into tauCaloFix

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigUpgradeTest

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20380-2019-01-16-18-41
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32313] (for remote access see the FAQ for MR reviewers)

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20380-2019-01-16-23-59
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32319] (for remote access see the FAQ for MR reviewers)

Looks like spurious CI start that timed out.

Something to worry about?

To me it looked like timeout.

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigUpgradeTest

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20380-2019-01-17-19-57
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32356] (for remote access see the FAQ for MR reviewers)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 50d9b704

added sweep:ignore label