Skip to content
Snippets Groups Projects

HypoTools merging logic

Merged Krzysztof Piotr Jamrog requested to merge kjamrog/athena:newjo into master
All threads resolved!

Continuation of work on getting rid of cache usage by implementing new way of HypoTools merging

Tagging @tbold

Edited by Krzysztof Piotr Jamrog

Merge request reports

Pipeline #669507 passed

Pipeline passed for f29840d0 on kjamrog:newjo

Merged by Vakhtang TsulaiaVakhtang Tsulaia 6 years ago (Jan 23, 2019 7:14pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This looks good to me, suggest to un WIP it in fact. Tagging @wlampl, as this makes specific algorithms actually mergable. This is feature needed to support HLT hypothesis algorithms w/o resorting to "internal caches" etc.

  • added 1 commit

    • f29840d0 - Removing unnecessary comment

    Compare with previous version

  • Krzysztof Piotr Jamrog unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Krzysztof Piotr Jamrog changed the description

    changed the description

  • mentioned in merge request !20499 (closed)

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    Adding @ssnyder as watcher

  • :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20397-2019-01-22-05-46
    :warning: Athena: number of compilation errors 0, warnings 36
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    For experts only: Jenkins output [CI-MERGE-REQUEST 32502] (for remote access see the FAQ for MR reviewers)

  • Unrelated overlay error. Approving.

    Tadej (L1)

  • added review-approved label and removed review-pending-level-1 label

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    Adding @ssnyder as watcher

  • added review-pending-level-1 label and removed review-approved label

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20397-2019-01-23-07-27
    :warning: Athena: number of compilation errors 0, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    For experts only: Jenkins output [CI-MERGE-REQUEST 32570] (for remote access see the FAQ for MR reviewers)

  • Vakhtang Tsulaia resolved all discussions

    resolved all discussions

  • mentioned in commit 47b92d85

  • Please register or sign in to reply
    Loading