Remove unnecessary (I)SiProperties(CH)Svc and LorentzAngleSvcSetup.py (ATLASRECTS-4048)

Remove unnecessary (I)SiProperties(CH)Svc and LorentzAngleSvcSetup.py.

Client configuration are updated accordingly.

https://its.cern.ch/jira/browse/ATLASRECTS-4048

Although updated codes should not affect anything of q221/q431 tests, RunTier0Tests.py was run and fine.

This merge request affects 2 packages:

• InnerDetector/InDetConditions/SiLorentzAngleSvc
• InnerDetector/InDetConditions/SiPropertiesSvc

added InnerDetector master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20405-2019-01-17-17-54
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32340] (for remote access see the FAQ for MR reviewers)

marked as a Work In Progress

changed the description

added 2 commits

• a6f8d66f - Revert "Remove SiPropertiesCHSvc and LorentzAngleSvcSetup.py"
• 4fbd9475 - Remove unnecessary SiPropertyCHSvc

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Remove unnecessary SiPropertiesCHSvc and LorentzAngleSvcSetup.py (ATLASRECTS-4048) to Remove unnecessary SiPropertiesCHSvc (ATLASRECTS-4048)

changed the description

This merge request affects 2 packages:

• InnerDetector/InDetConditions/SiLorentzAngleSvc
• InnerDetector/InDetConditions/SiPropertiesSvc

LorentzAngleSvcSetup.py is still in use.

marked as a Work In Progress

added 9 commits

• 1e761813 - Revive InDetDetDescrExample/ReadSiDetectorElements_jobOptions.py
• b155c67c - Revive InDetGeometryValidation/ReadSiDetectorElements_jobOptions.py
• 00362aea - Remove obsolete configuration. PixelSiPropertiesSvc and SCT_SiPropertiesSvc were…
• 5fd5ff03 - Move from lorentzAngleSvc to PixelLorentzAngleToolSetup
• 5233c9e9 - Move from lorentzAngleSvc to PixelLorentzAngleToolSetup
• fdf18064 - Move from lorentzAngleSvc SCTLorentzAngleToolSetup
• 0e4495b9 - Move from lorentzAngleSvc SCTLorentzAngleToolSetup
• 6da0985f - Remove LorentzAngleSvcSetup.py
• 3d0fbc82 - Migrate from SiPropertiesSvc to SiPropertiesTool

Compare with previous version

added 1 commit

• 4758a9f6 - Remove SiPropertiesSvc class

Compare with previous version

changed title from WIP: Remove unnecessary SiPropertiesCHSvc (ATLASRECTS-4048) to WIP: Remove unnecessary (I)SiProperties(CH)Svc and LorentzAngleSvcSetup.py (ATLASRECTS-4048)

changed the description

unmarked as a Work In Progress

This merge request affects 8 packages:

• InnerDetector/InDetConditions/SiLorentzAngleSvc
• InnerDetector/InDetConditions/SiPropertiesSvc
• InnerDetector/InDetDigitization/FastSiDigitization
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetDetDescrExample
• InnerDetector/InDetValidation/InDetGeometryValidation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Tools/RDOAnalysis

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added Digitization JetEtmiss Simulation labels

changed the description

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20405-2019-01-18-05-14
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32370] (for remote access see the FAQ for MR reviewers)

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20405-2019-01-18-07-59
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32384] (for remote access see the FAQ for MR reviewers)

Jenkins please retry a build

This merge request affects 8 packages:

• InnerDetector/InDetConditions/SiLorentzAngleSvc
• InnerDetector/InDetConditions/SiPropertiesSvc
• InnerDetector/InDetDigitization/FastSiDigitization
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetDetDescrExample
• InnerDetector/InDetValidation/InDetGeometryValidation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Tools/RDOAnalysis

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20405-2019-01-18-16-59
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32407] (for remote access see the FAQ for MR reviewers)

Jenkins please retry a build

This merge request affects 8 packages:

• InnerDetector/InDetConditions/SiLorentzAngleSvc
• InnerDetector/InDetConditions/SiPropertiesSvc
• InnerDetector/InDetDigitization/FastSiDigitization
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetDetDescrExample
• InnerDetector/InDetValidation/InDetGeometryValidation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Tools/RDOAnalysis

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20405-2019-01-19-18-57
Athena: number of compilation errors 0, warnings 36
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32439] (for remote access see the FAQ for MR reviewers)

changed the description

Looks OK, approving.

Tadej (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 00c89779

added sweep:ignore label