FastCaloSim+ISF_FastCaloSimServices: Working to make FastShowerCellBuilderTool const.

Remove m_rndm member. Create it instead as a local variable and pass it where required.

This merge request affects 2 packages:

• Simulation/FastShower/FastCaloSim
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added Simulation master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20421-2019-01-18-06-57
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32372] (for remote access see the FAQ for MR reviewers)

Probably need to update references:

The following tests FAILED:
	945 - FastCaloSim_FastShowerCellBuilderTool_test_ctest (Failed)
[ERROR_MESSAGE]
Errors while running CTest

added review-user-action-required label and removed review-pending-level-1 label

CI problem; bad pcm. Retry.

Jenkins please try a rebuild.

This merge request affects 2 packages:

• Simulation/FastShower/FastCaloSim
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20421-2019-01-19-04-49
Athena: number of compilation errors 0, warnings 36
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32426] (for remote access see the FAQ for MR reviewers)

Unit tests show StreamerInfo warnings, but are ok otherwise. These can't be due to this MR and do not reproduce either in local builds or in the nightly builds. Must be a CI problem. Since unit tests are ok otherwise, i'd suggest going ahead and merging.

This merge request affects 2 packages:

• Simulation/FastShower/FastCaloSim
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20421-2019-01-20-14-10
Athena: number of compilation errors 0, warnings 36
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32445] (for remote access see the FAQ for MR reviewers)

merged

mentioned in commit 65b6536d

added sweep:ignore label