Skip to content
Snippets Groups Projects

Remove CURL, master branch (2019.01.18.)

Merged Attila Krasznahorkay requested to merge akraszna/athena:RemoveCURL-master-20190118 into master

Removed the usage of FindCURL.cmake from CollectionUtilities.

The package probably did use CURL at one point of its file, but it doesn't use it by now. So there's no need for it to set it up for its build.

Note that this is why the current CentOS 7 nightlies don't show a build error, even though they fail to find CURL.

http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/GITWebArea/nightlies/master/2019-01-17T2139/Athena/x86_64-centos7-gcc8-opt/Athena/cmake_config.log.html

-- Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)

Since as ATLINFR-2820 explains, this becomes an error with CMake 3.13, the simplest was just to remove this unneeded dependency from the CollectionUtilities package.

Merge request reports

Pipeline #665466 passed

Pipeline passed for 6dc147bc on akraszna:RemoveCURL-master-20190118

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 6 years ago (Jan 18, 2019 7:04pm UTC)

Merge details

  • Changes merged into with fae8e1cf.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading