Merge tag 21.0.91-21.0.92 into 21.9

This merge request merges the changes from the 21.0 branch between release/21.0.90 and release/21.0.91 into the 21.9 branch. This is done via a merge of release/21.3.9.

release/21.0.91 is a Tier0 release. It's FT0-violating. It includes the FT0V MRs: athenaprivate1!16171, athenaprivate1!15893, athenaprivate1!15117, athenaprivate1!16009, athenaprivate1!16049

release/21.0.92 is a Tier0 release. It's FT0-violating. It includes the FT0V MRs: athenaprivate1!15481, athenaprivate1!16537 The latter of which is the merge of 21.1 into 21.0

mentioned in merge request !20388 (closed)

This merge request affects 15 packages:

• DataQuality/DataQualityConfigurations
• DataQuality/DataQualityUtils
• Event/ByteStreamCnvSvcBase
• Event/EventOverlay/EventOverlayJobTransforms
• Event/EventOverlay/OverlayMonitoringRTT
• Event/xAOD/xAODForward
• Event/xAOD/xAODForwardAthenaPool
• HLT/HLTTestApps
• HLT/Trigger/TrigMonitoring/TrigOnlineMonitor
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetDetDescr/PixelGeoModel
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetExample/InDetTrigRecExample
• InnerDetector/InDetMonitoring/InDetAlignmentMonitoring

Adding @jchapman ,@tkharlam ,@wiedenma ,@ahaas ,@fwinkl ,@tadej ,@rbielski as watchers

added 21.9 DQ Digitization EDM InnerDetector Overlay Trigger review-pending-level-1 labels

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20442-2019-01-18-14-00
Athena: number of compilation errors 2, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST 32404] (for remote access see the FAQ for MR reviewers)

added 1 commit

• 2b16cef7 - Merge tag 21.0.91-21.0.92 into 21.9

Compare with previous version

Couple of missed conflict resolutions - now fixed.

This merge request affects 15 packages:

• DataQuality/DataQualityConfigurations
• DataQuality/DataQualityUtils
• Event/ByteStreamCnvSvcBase
• Event/EventOverlay/EventOverlayJobTransforms
• Event/EventOverlay/OverlayMonitoringRTT
• Event/xAOD/xAODForward
• Event/xAOD/xAODForwardAthenaPool
• HLT/HLTTestApps
• HLT/Trigger/TrigMonitoring/TrigOnlineMonitor
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetDetDescr/PixelGeoModel
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetExample/InDetTrigRecExample
• InnerDetector/InDetMonitoring/InDetAlignmentMonitoring

Adding @jchapman ,@tkharlam ,@wiedenma ,@ahaas ,@fwinkl ,@tadej ,@rbielski as watchers

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20442-2019-01-18-16-45
Athena: number of compilation errors 0, warnings 9
For experts only: Jenkins output [CI-MERGE-REQUEST 32412] (for remote access see the FAQ for MR reviewers)

The change in output of SimulationTier0Test is expected due to the G4 version change. I'm not sure about the failure of UpgradeTests_required-test though. @swaban does this test usually pass?

Required tests usually do pass in 21.9, unless the code came from 20.20.X.Y, where Upgrade Tests do fail: https://atlas-rtt.cern.ch/index.php?q=(packagename=*;branch=20.20.X.Y-VAL;project=AtlasProduction;verbosity=vvv;)

OK - thanks for the info. I will have to try to compile all the changes locally in that case. :-(

added review-user-action-required label

OK - so I did a private build of my branch and ran the RunUpgradeTests.py -n script. The local test failed with the same output as the the CI test, but this time I was able to look at the digitization log file:

12:55:05 WARNING: cannot load libMuonCSC_CnvTools.so for factory CscDigitToCscRDOTool
12:55:05 WARNING: libeformat_write.so: cannot open shared object file: No such file or directory
12:55:05 ToolSvc             ERROR Cannot create tool CscDigitToCscRDOTool (No factory found)
12:55:05 CscDigitToCscRDO    FATAL /build1/openbuild/athena/MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/CscDigitToCscRDO.cxx:25 (StatusCode CscDigitToCscRDO::initialize()): code 0: m_digTool.retrieve()
12:55:05 MemStatAuditor       INFO Memory usage has changed after CscDigitToCscRDO Initialize 	virtual size = 1485.16 MB 	resident set size = 1016.9 MB deltaVsize = 0  MB
12:55:05 AthAlgSeq           ERROR Unable to initialize Algorithm CscDigitToCscRDO

(I'm assuming here that the error in my local build is the same as in the CI build, but it's the best info we have a the moment.) eformat-write is pulled in from tdaq-common: https://gitlab.cern.ch/atlas/athena/blob/21.9/MuonSpectrometer/MuonCnv/MuonCSC_CnvTools/CMakeLists.txt#L37 The atlasexternals version is updated in this merge request atlasexternals@1.0.32...1.0.43 There are a few changes related to tdaq configuration in that diff. Perhaps there is something in 21.9 that needs to be updated in order to work with this?

Jenkins please retry a build

Retrying the build as I think the CI logs might be more accessible now.

This merge request affects 15 packages:

• DataQuality/DataQualityConfigurations
• DataQuality/DataQualityUtils
• Event/ByteStreamCnvSvcBase
• Event/EventOverlay/EventOverlayJobTransforms
• Event/EventOverlay/OverlayMonitoringRTT
• Event/xAOD/xAODForward
• Event/xAOD/xAODForwardAthenaPool
• HLT/HLTTestApps
• HLT/Trigger/TrigMonitoring/TrigOnlineMonitor
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetDetDescr/PixelGeoModel
• InnerDetector/InDetDigitization/PixelRadDamDigitization
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetExample/InDetTrigRecExample
• InnerDetector/InDetMonitoring/InDetAlignmentMonitoring

Adding @jchapman ,@tkharlam ,@wiedenma ,@ahaas ,@fwinkl ,@tadej ,@rbielski as watchers

removed review-user-action-required label

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20442-2019-01-24-17-53
Athena: number of compilation errors 0, warnings 166
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32699] (for remote access see the FAQ for MR reviewers)

OK, so in this re-run of the CI-pipeline the HITtoRDO step succeeded, so this is different from my attempt to build the branch locally. I heard in the Core SW meeting that @akraszna is going to work on a patch for master which sounds like it might be related to the issue I had in my private build. Then at least I would be able to reproduce the CI results.

Another idea might be to patch RunUpgradeTests.py to print out any ERROR level messgaes from log files? What do you think @amete?

Hi @jchapman,

Let me tag @nstyles on the RunUpgradeTests.py. However, I think it would be a lot easier (and cleaner) to simply grep some relevant information from the logs on the CI tests which'll make it visible on the NICOS page. That' what we're doing for qTests, e.g. grep -i "warning\|error\|fatal\|diff\|sync" run_q221/q221.log.

-s