Upgrade python code style ckecker to flake8 3.6.0

• Upgrade the python code style ckecker flake8 to its latest version (3.6.0) and all required dependencies as well
• Fix a few additional code issues for the packages were the flake8 unit tests is used
  • catching bare exceptions
  • use double-backslash to print backslash

unmarked as a Work In Progress

This merge request affects 5 packages:

• Control/AthenaCommon
• Control/AthenaConfiguration
• External/AtlasPyFwdBwdPorts
• HLT/Trigger/TrigControl/TrigCommon
• Trigger/TriggerCommon/TriggerJobOpts

Adding @fwinkl ,@wiedenma ,@ssnyder ,@rbielski as watchers

added Core Externals Trigger master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20523-2019-01-22-21-09
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32544] (for remote access see the FAQ for MR reviewers)

The changes look fine to me and there are no CI issues. Approving.

Cheers,

Jason (L1 shifter)

added review-approved label and removed review-pending-level-1 label

@fwinkl : this one has developed some conflicts. Could you please look into it?

added review-user-action-required label

added 99 commits

• aa2e467d...1229b7f5 - 97 commits from branch atlas:master
• 9f12f6e3 - Upgrade to flake8 3.6.0
• cd3a6322 - Fix python code style warnings

Compare with previous version

added 1 commit

• 450e5381 - Fix python code style warnings

Compare with previous version

removed review-user-action-required label

Jenkins please retry a build

This merge request affects 5 packages:

• Control/AthenaCommon
• Control/AthenaConfiguration
• External/AtlasPyFwdBwdPorts
• HLT/Trigger/TrigControl/TrigCommon
• Trigger/TriggerCommon/TriggerJobOpts

Adding @fwinkl ,@wiedenma ,@ssnyder ,@rbielski as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20523-2019-01-25-01-38
Athena: number of compilation errors 0, warnings 30
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32715]

merged

mentioned in commit 9b3f20a6

added sweep:ignore label