Skip to content
Snippets Groups Projects

Monitored: Explicit fill will disable automatic filling

Merged Frank Winklmeier requested to merge fwinkl/athena:monitored_autofill into master
All threads resolved!

Calling Monitored::Group::fill() will now disable the automatic filling to avoid double filling when the group goes out of scope. Added a test-case in the unit tests and updated documentation.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold resolved all discussions

    resolved all discussions

  • Looks good to me. Failed Trigger_MT-test#Trigger_MT-test also seen in other MRs, presumably not related. Approving.

    Serhat (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 889e8f81

  • Please register or sign in to reply
    Loading