Skip to content
Snippets Groups Projects

Tidy up python config in RngComps and BCM_Digitization

Merged Rupert Tombs requested to merge rtombs/athena:py-config-tidy into master
All threads resolved!

One commit: Remove outdated imports in BCM_DigitizationConfigNew.py. Relocate RandomServices_test.py to the test directory.

Merge request reports

Pipeline #673197 passed

Pipeline passed for af6d3e4e on rtombs:py-config-tidy

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 6 years ago (Jan 24, 2019 5:46pm UTC)

Merge details

  • Changes merged into master with 1111eeb3.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 2 packages:

    • Control/RngComps
    • InnerDetector/InDetDigitization/BCM_Digitization

    Adding @jchapman ,@ssnyder as watchers

  • This merge request affects 2 packages:

    • Control/RngComps
    • InnerDetector/InDetDigitization/BCM_Digitization

    Adding @jchapman ,@ssnyder as watchers

  • Jenkins please retry a build

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Control/RngComps
    • InnerDetector/InDetDigitization/BCM_Digitization

    Adding @jchapman ,@ssnyder as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20566-2019-01-24-04-18
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32632] (for remote access see the FAQ for MR reviewers)

  • Tadej Novak resolved all discussions

    resolved all discussions

  • The changes look ok. Adding review-approved label.

    L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 1111eeb3

  • Please register or sign in to reply
    Loading