Refactor Tile bytestream converters for TMDB

Digits for TMDB from bytestream are unpacked in the same time when Tile digits are requested and upacked and put directly into StoreGate ignoring standard conversion mechanism. The same is done in the case of unpacking raw channels for TMDB. This is not very good for AthenaMT (especially for scheduler).

Tile bytestream converters have been refactored to unpack digits and raw channels for TMDB only if they are requested (needed) using standard conversion mechanism.

Unit tests for reading Tile digits and raw channels from bytestream and the corresponding reference files have been updated accordingly.

This merge request affects 3 packages:

• Event/EventOverlay/EventOverlayJobTransforms
• Reconstruction/RecExample/RecExCommon
• TileCalorimeter/TileSvc/TileByteStream

Adding @jchapman ,@ahaas ,@pavol ,@tkharlam ,@tadej ,@solodkov ,@harkusha as watchers

added EDM JetEtmiss Overlay Reconstruction Tile master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20648-2019-01-25-22-33
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32784]

Unfortunately, there are conflicts now.

added review-user-action-required label and removed review-pending-level-1 label

added 75 commits

• 3f1c952a...1b39d5d0 - 74 commits from branch atlas:master
• 286d3cb3 - TileByteStream: Update reference files to resolve merge conflicts

Compare with previous version

This merge request affects 3 packages:

• Event/EventOverlay/EventOverlayJobTransforms
• Reconstruction/RecExample/RecExCommon
• TileCalorimeter/TileSvc/TileByteStream

Adding @jchapman ,@ahaas ,@pavol ,@tkharlam ,@tadej ,@solodkov ,@harkusha as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20648-2019-01-28-16-47
Athena: number of compilation errors 0, warnings 28
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32861]

@harkusha, unfortunately the conflicts are still not resolved.

Cheers, Johannes (lvl1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @jmellent,

Why do you think that the merge conflicts are not resolved? I see only failed test.

But, frankly speaking, I'm very doubt that the test failed because of this merge request.

I'd propose to restart build.

Cheers, Siarhei

You are right. My comment was misleading. I'll give it another try.

Jenkins please retry a build

Jenkins please retry a build

It should be exactly "Jenkins please retry a build" without any additional words in comment

This merge request affects 3 packages:

• Event/EventOverlay/EventOverlayJobTransforms
• Reconstruction/RecExample/RecExCommon
• TileCalorimeter/TileSvc/TileByteStream

Adding @jchapman ,@ahaas ,@pavol ,@tkharlam ,@tadej ,@solodkov ,@harkusha as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20648-2019-01-29-02-27
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32907]

Looks OK. Approving.

Tadej (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ef22f8bc

added sweep:ignore label